cmssw fix out of bound error in Phase-2 L1 Calorimeter barrel emulator

This PR addresses the out-of-bounds error in Phase2L1RCT.h raised in #46372.

PR description:

This PR addresses the out-of-bounds error in Phase2L1RCT.h raised in #46372.

PR validation:

The original emulator has been re-run and checked that the outputs are unchanged.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Oct 22 '24 11:10 skkwan

cms-bot internal usage

Oct 22 '24 11:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46472/42330

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h modified in PR(s): #46372

Oct 22 '24 11:10 cmsbuild

A new Pull Request was created by @skkwan for master.

It involves the following packages:

L1Trigger/L1CaloTrigger (l1, upgrade)

@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Oct 22 '24 11:10 cmsbuild

Hi @smuzaffar, this PR should be for the master branch.

Thanks, Stephanie

Oct 22 '24 11:10 skkwan

please test

Oct 22 '24 12:10 smuzaffar

test parameters:

workflow = 23634.0

Oct 22 '24 12:10 smuzaffar

please test for CMSSW_14_2_UBSAN_X

Oct 22 '24 12:10 smuzaffar

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42337/summary.html COMMIT: 12501e25c6793d1cc2c7d25ff6ccde090f58d4a5 CMSSW: CMSSW_14_2_X_2024-10-21-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46472/42337/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@SanghyunKo cms-sw/cmssw#46423
@trackreco cms-sw/cmssw#46324

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42337/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42337/git-merge-result

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 465 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3566331
DQMHistoTests: Total failures: 84267
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3482044
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 201 log files, 171 edm output root files, 46 DQM output files
TriggerResults: no differences found

Oct 22 '24 16:10 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42338/summary.html COMMIT: 12501e25c6793d1cc2c7d25ff6ccde090f58d4a5 CMSSW: CMSSW_14_2_UBSAN_X_2024-10-21-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46472/42338/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@SanghyunKo cms-sw/cmssw#46423
@trackreco cms-sw/cmssw#46324

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42338/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42338/git-merge-result

Oct 22 '24 17:10 cmsbuild

please test

lets rerun the default tests based on newer IB

Oct 23 '24 07:10 smuzaffar

UBSAN test shows that L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1257:24: runtime error: index 25 out of bounds for type 'ap_uint [24]' is gone/fixed

Oct 23 '24 07:10 smuzaffar

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42349/summary.html COMMIT: 12501e25c6793d1cc2c7d25ff6ccde090f58d4a5 CMSSW: CMSSW_14_2_X_2024-10-22-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46472/42349/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3665145
DQMHistoTests: Total failures: 510
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3664615
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 206 log files, 175 edm output root files, 47 DQM output files
TriggerResults: no differences found

Oct 23 '24 11:10 cmsbuild

+l1

Oct 28 '24 10:10 aloeliger

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46472/42391

Oct 28 '24 13:10 cmsbuild

Pull request #46472 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

Oct 28 '24 13:10 cmsbuild

please test

Oct 28 '24 13:10 aloeliger

@cmsbuild abort

Nov 02 '24 17:11 srimanob

@cmsbuild please test

Nov 02 '24 17:11 srimanob

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42561/summary.html COMMIT: 091bcb1fda0d5b87e26376476c8a916d0dab3622 CMSSW: CMSSW_14_2_X_2024-11-02-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46472/42561/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3668383
DQMHistoTests: Total failures: 531
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3667832
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 206 log files, 175 edm output root files, 47 DQM output files
TriggerResults: no differences found

Nov 02 '24 21:11 cmsbuild

+Upgrade

Nov 03 '24 15:11 Moanwar

+l1

Nov 06 '24 15:11 aloeliger

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Nov 06 '24 15:11 cmsbuild

+1

Nov 06 '24 15:11 mandrenguyen