cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Run3-hcx378X Backport #46467 to CMSSW_14_1_X which makes RPD as a valid detector in the 2023 scenario

Open bsunanda opened this issue 1 year ago • 8 comments

PR description:

Backport #46467 to CMSSW_14_1_X which makes RPD as a valid detector in the 2023 scenario

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46467

bsunanda avatar Oct 22 '24 06:10 bsunanda

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)
  • Geometry/CMSCommonData (upgrade, geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fabiocos, @martinamalberti, @missirol, @slomeo, @vargasa this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 22 '24 06:10 cmsbuild

cms-bot internal usage

cmsbuild avatar Oct 22 '24 06:10 cmsbuild

Please explain why this is needed in 14_1_X which is a closed release cycle

mandrenguyen avatar Oct 22 '24 06:10 mandrenguyen

I understood from yesterday's AlCaReco meeting that there is a plan to ReReco 2023 HI data using 14_1_X. In 14_1_X, RPD is an invalid detector. So if 14_1_X is used to do ReReco, one needs this PR to be included.


From: Matthew Nguyen @.> Sent: 22 October 2024 12:03 To: cms-sw/cmssw @.> Cc: Sunanda Banerjee @.>; Mention @.> Subject: Re: [cms-sw/cmssw] Run3-hcx378X Backport #46467 to CMSSW_14_1_X which makes RPD as a valid detector in the 2023 scenario (PR #46468)

Please explain why this is needed in 14_1_X which is a closed release cycle

— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/46468#issuecomment-2428371228, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGMZOTCBHYZJXSTF2NATQDZ4XWSXAVCNFSM6AAAAABQLWCE42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRYGM3TCMRSHA. You are receiving this because you were mentioned.Message ID: @.***>

bsunanda avatar Oct 22 '24 06:10 bsunanda

hold Since RPD is not being reconstructed in 2024 data presumably it is not needed in 2023 either.

mandrenguyen avatar Oct 22 '24 07:10 mandrenguyen

Pull request has been put on hold by @mandrenguyen They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar Oct 22 '24 07:10 cmsbuild

@cmsbuild Please test

bsunanda avatar Oct 23 '24 11:10 bsunanda

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e21204/42356/summary.html COMMIT: f0a57ea36941689a968b5b807605b88939532516 CMSSW: CMSSW_14_1_X_2024-10-23-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46468/42356/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3562835
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3562812
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 23 '24 14:10 cmsbuild

+geometry

bsunanda avatar Oct 28 '24 09:10 bsunanda

unhold

mandrenguyen avatar Oct 29 '24 07:10 mandrenguyen

@bsunanda Does the PR have any effect with the RPD reconstruction disabled in 14_1_X?

mandrenguyen avatar Oct 29 '24 07:10 mandrenguyen

No. If RPD reconstruction is enabled sometime, this will just allow it to happen. If the reconstruction is disabled, this PR will have no effect.


From: Matthew Nguyen @.> Sent: 29 October 2024 13:16 To: cms-sw/cmssw @.> Cc: Sunanda Banerjee @.>; Mention @.> Subject: Re: [cms-sw/cmssw] Run3-hcx378X Backport #46467 to CMSSW_14_1_X which makes RPD as a valid detector in the 2023 scenario (PR #46468)

@bsunandahttps://github.com/bsunanda Does the PR have any effect with the RPD reconstruction disabled in 14_1_X?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/46468#issuecomment-2443478011, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGMZOXMJUVTPABIMKONPNDZ544OLAVCNFSM6AAAAABQLWCE42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTGQ3TQMBRGE. You are receiving this because you were mentioned.Message ID: @.***>

bsunanda avatar Oct 29 '24 07:10 bsunanda

+Upgrade

Moanwar avatar Oct 29 '24 08:10 Moanwar

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 29 '24 08:10 cmsbuild

+1

mandrenguyen avatar Oct 29 '24 16:10 mandrenguyen