cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Run3-hcx378 Make 2023 Geometry scenario to accept RPD as a valid detector

Open bsunanda opened this issue 1 year ago • 8 comments

PR description:

Make 2023 Geometry scenario to accept RPD as a valid detector

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backported to CMSSW_14_1_X using #46468

bsunanda avatar Oct 22 '24 06:10 bsunanda

cms-bot internal usage

cmsbuild avatar Oct 22 '24 06:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46467/42328

cmsbuild avatar Oct 22 '24 06:10 cmsbuild

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fabiocos, @martinamalberti, @missirol, @slomeo, @vargasa this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 22 '24 06:10 cmsbuild

@cmsbuild Please test

bsunanda avatar Oct 22 '24 06:10 bsunanda

+1

Size: This PR adds an extra 40KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d7d23/42333/summary.html COMMIT: 8dddf08173aa56f2cdbb99d4b3f6a6f2969db960 CMSSW: CMSSW_14_2_X_2024-10-21-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46467/42333/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Oct 22 '24 10:10 cmsbuild

+geometry

bsunanda avatar Oct 23 '24 07:10 bsunanda

@subirsarkar Please approve this

bsunanda avatar Oct 23 '24 07:10 bsunanda

Upgrade

subirsarkar avatar Oct 23 '24 17:10 subirsarkar

@subirsarkar Please type +Upgrade rather than Upgrade

bsunanda avatar Oct 24 '24 07:10 bsunanda

+Upgrade

subirsarkar avatar Oct 24 '24 12:10 subirsarkar

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 24 '24 12:10 cmsbuild

+1

mandrenguyen avatar Oct 24 '24 19:10 mandrenguyen