cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Run3-sim159 Update the references to hcalRecNumbering files to have more appropriate flags to mark the Run2 period

Open bsunanda opened this issue 1 year ago • 8 comments

PR description:

Update the references to hcalRecNumbering files to have more appropriate flags to mark the Run2 period

PR validation:

Tested with scripts in SimG4Core/PrintGeomInfo

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar Oct 21 '24 13:10 bsunanda

cms-bot internal usage

cmsbuild avatar Oct 21 '24 13:10 cmsbuild

@cmsbuild Please test

bsunanda avatar Oct 21 '24 13:10 bsunanda

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46464/42326

cmsbuild avatar Oct 21 '24 13:10 cmsbuild

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/CMSCommonData (geometry, upgrade)
  • SimG4Core/PrintGeomInfo (simulation)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 21 '24 13:10 cmsbuild

+1

Size: This PR adds an extra 32KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74b70a/42325/summary.html COMMIT: 32f31c075118a62607ec4b08edfce3e1aab787aa CMSSW: CMSSW_14_2_X_2024-10-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46464/42325/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566331
  • DQMHistoTests: Total failures: 502
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565809
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 21 '24 17:10 cmsbuild

+geometry

bsunanda avatar Oct 22 '24 06:10 bsunanda

@subirsarkar Please approve this PR

bsunanda avatar Oct 23 '24 07:10 bsunanda

+Upgrade

subirsarkar avatar Oct 23 '24 17:10 subirsarkar

+1

civanch avatar Oct 25 '24 17:10 civanch

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 25 '24 17:10 cmsbuild

+1

mandrenguyen avatar Oct 28 '24 05:10 mandrenguyen

+1

mandrenguyen avatar Oct 28 '24 05:10 mandrenguyen