cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[14_1_X] Update the PbPb skims for 2024 data taking

Open flodamas opened this issue 1 year ago • 3 comments

PR description:

Backport of #46447

flodamas avatar Oct 21 '24 09:10 flodamas

A new Pull Request was created by @flodamas for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

  • Backported from #46447

cmsbuild avatar Oct 21 '24 09:10 cmsbuild

cms-bot internal usage

cmsbuild avatar Oct 21 '24 09:10 cmsbuild

backport of https://github.com/cms-sw/cmssw/pull/46447

mandrenguyen avatar Oct 22 '24 10:10 mandrenguyen

@cms-sw/pdmv-l2, could you please test it?

youyingli avatar Oct 24 '24 15:10 youyingli

please test

mandrenguyen avatar Oct 24 '24 15:10 mandrenguyen

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42381/summary.html COMMIT: 041c459a6d356e11700476ec7dda5a6eef92f42a CMSSW: CMSSW_14_1_X_2024-10-24-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46458/42381/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3562835
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3562803
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 24 '24 19:10 cmsbuild

Pull request #46458 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

cmsbuild avatar Oct 25 '24 09:10 cmsbuild

Pull request #46458 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

cmsbuild avatar Oct 26 '24 09:10 cmsbuild

please test

mandrenguyen avatar Oct 27 '24 11:10 mandrenguyen

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42401/summary.html COMMIT: da5d10df064b5784c6ab4cca0aefd883204f2c64 CMSSW: CMSSW_14_1_X_2024-10-27-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46458/42401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3562835
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3562809
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 27 '24 15:10 cmsbuild

Pull request #46458 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

cmsbuild avatar Oct 29 '24 10:10 cmsbuild

please test

mandrenguyen avatar Oct 29 '24 11:10 mandrenguyen

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42438/summary.html COMMIT: 60b49432760f2605b84b161808eeaa86d146ed90 CMSSW: CMSSW_14_1_X_2024-10-28-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46458/42438/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3565646
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 29 '24 17:10 cmsbuild

urgent

mandrenguyen avatar Oct 30 '24 11:10 mandrenguyen

Pull request #46458 was updated. @AdrianoDee, @cmsbuild, @dickychant, @miquork can you please check and sign again.

cmsbuild avatar Oct 31 '24 19:10 cmsbuild

please test

mandrenguyen avatar Oct 31 '24 19:10 mandrenguyen

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42521/summary.html COMMIT: 20891cbc2f8f2de0e9f391af58585015ac4f0f3f CMSSW: CMSSW_14_1_X_2024-10-31-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46458/42521/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @cfmcginn cms-sw/cmssw#46514

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42521/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42521/git-merge-result

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3565643
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 31 '24 23:10 cmsbuild

+pdmv

AdrianoDee avatar Nov 01 '24 05:11 AdrianoDee

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Nov 01 '24 05:11 cmsbuild

+1

mandrenguyen avatar Nov 01 '24 09:11 mandrenguyen