cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Update the PbPb skims for 2024 data taking

Open flodamas opened this issue 1 year ago • 6 comments

PR description:

Update of the configuration of the PbPb skims in view of the 2024 HI run. The ZMM skim is replaced by the ZMu skimming code to avoid duplicates such that a unique skimmed dataset can be used for both Z boson physics analyses and muon tag-and-probe.

PR validation:

Unit tests passed successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_1_X for the HI run.

flodamas avatar Oct 18 '24 18:10 flodamas

@flodamas, CMSSW_14_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. In future, please use cmssw master branch to submit your changes.

cmsbuild avatar Oct 18 '24 18:10 cmsbuild

cms-bot internal usage

cmsbuild avatar Oct 18 '24 18:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46447/42307

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File Configuration/Skimming/python/autoSkim.py modified in PR(s): #46434

cmsbuild avatar Oct 18 '24 18:10 cmsbuild

A new Pull Request was created by @flodamas for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 18 '24 18:10 cmsbuild

please test

mandrenguyen avatar Oct 20 '24 09:10 mandrenguyen

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42313/summary.html COMMIT: 7ded0284b2027ace519dda535cfe90bb214b3bfb CMSSW: CMSSW_14_2_X_2024-10-20-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46447/42313/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566331
  • DQMHistoTests: Total failures: 453
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3565856
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 20 '24 14:10 cmsbuild

Hi, I would like to make sure if the update is also available to ReReco 2023 Heavy ion data even in the future.

youyingli avatar Oct 24 '24 15:10 youyingli

Hi, I would like to make sure if the update is also available to ReReco 2023 Heavy ion data even in the future.

Hi @youyingli I'm not sure I understand the comment. These are prompt skims, we would not run them in a reprocessing.

mandrenguyen avatar Oct 24 '24 15:10 mandrenguyen

Hi, I would like to make sure if the update is also available to ReReco 2023 Heavy ion data even in the future.

Hi @youyingli I'm not sure I understand the comment. These are prompt skims, we would not run them in a reprocessing.

OK, thanks. Just make sure if these skims will also join 2023 Heavy ion data reprocessing in the future. Now I understand.

@cms-sw/pdmv-l2, could you please sign it?

youyingli avatar Oct 24 '24 15:10 youyingli

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46447/42366

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File Configuration/Skimming/python/autoSkim.py modified in PR(s): #46434, #46499

cmsbuild avatar Oct 25 '24 09:10 cmsbuild

Pull request #46447 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

cmsbuild avatar Oct 25 '24 09:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46447/42370

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File Configuration/Skimming/python/autoSkim.py modified in PR(s): #46434, #46499

cmsbuild avatar Oct 26 '24 08:10 cmsbuild

Pull request #46447 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

cmsbuild avatar Oct 26 '24 08:10 cmsbuild

please test

mandrenguyen avatar Oct 27 '24 10:10 mandrenguyen

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42400/summary.html COMMIT: 322f46fd42f5fa035aecad177bca619ff84f95ec CMSSW: CMSSW_14_2_X_2024-10-27-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569177
  • DQMHistoTests: Total failures: 404
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3568751
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 27 '24 15:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46447/42403

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File Configuration/Skimming/python/autoSkim.py modified in PR(s): #46434, #46499

cmsbuild avatar Oct 29 '24 09:10 cmsbuild

Pull request #46447 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

cmsbuild avatar Oct 29 '24 09:10 cmsbuild

please test

mandrenguyen avatar Oct 29 '24 11:10 mandrenguyen

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42439/summary.html COMMIT: 94e9f8fe11482a9d7f80a11e5284e20821199f01 CMSSW: CMSSW_14_2_X_2024-10-28-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42439/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
  • 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
  • 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log
Expand to see more relval errors ...
  • 2024.101001
  • 2024.000001
  • 2024.001001
  • 2024.100001
  • 2024.101001

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569177
  • DQMHistoTests: Total failures: 389
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3568766
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 29 '24 17:10 cmsbuild

ignore tests-rejected with ib-failure

mandrenguyen avatar Oct 29 '24 17:10 mandrenguyen

urgent @cms-sw/pdmv-l2 We will need a release with the prompt skims shortly for PbPb data taking.

mandrenguyen avatar Oct 29 '24 17:10 mandrenguyen

flodamas as we anticipated this one is in conflict after we merged the other two skim PRs. Please resolve it.

mandrenguyen avatar Oct 30 '24 21:10 mandrenguyen

+pdmv

AdrianoDee avatar Oct 30 '24 21:10 AdrianoDee

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 30 '24 21:10 cmsbuild

(signed anyway, will sign again after the conflicts are solved)

AdrianoDee avatar Oct 30 '24 21:10 AdrianoDee

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46447/42457

cmsbuild avatar Oct 31 '24 15:10 cmsbuild

Pull request #46447 was updated. @cmsbuild can you please check and sign again.

cmsbuild avatar Oct 31 '24 15:10 cmsbuild

please test

mandrenguyen avatar Oct 31 '24 15:10 mandrenguyen

-1

Failed Tests: RelVals RelVals-INPUT Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42514/summary.html COMMIT: 1153f7c68a93bb1ab939b8384c63874ee9ed5b45 CMSSW: CMSSW_14_2_X_2024-10-30-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @smuzaffar cms-sw/cmssw#46554
  • @RSalvatico cms-sw/cmssw#46558
  • @Cvico cms-sw/cmssw#46492
  • @smuzaffar cms-sw/cmssw#46528
  • @cfmcginn cms-sw/cmssw#46499
  • @AdrianoDee cms-sw/cmssw#46521
  • @hqucms cms-sw/cmssw#46273
  • @stahlleiton cms-sw/cmssw#46434
  • @AdrianoDee cms-sw/cmssw#46559

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42514/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-799846/42514/git-merge-result

RelVals

----- Begin Fatal Exception 31-Oct-2024 17:50:37 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_PAT_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file PhysicsTools/NanoAOD/data/el_BDTG_2022.weights.xml anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.023_RunZeroBias2022B


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 31-Oct-2024 17:50:40 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_PAT_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file PhysicsTools/NanoAOD/data/el_BDTG_2022.weights.xml anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.043_RunZeroBias2022C


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 31-Oct-2024 17:50:46 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_PAT_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file PhysicsTools/NanoAOD/data/el_BDTG_2022.weights.xml anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46447/42514/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.063_RunZeroBias2022D


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 2500.0022500.002_NANOmc106Xul17v2/step2_NANOmc106Xul17v2.log
  • 2500.0012500.001_NANOmc106Xul16v2/step2_NANOmc106Xul16v2.log
  • 2500.0032500.003_NANOmc106Xul18v2/step2_NANOmc106Xul18v2.log
Expand to see more relval errors ...

cmsbuild avatar Oct 31 '24 18:10 cmsbuild

ignore tests-rejected with ib-failure errors clearly unrelated to this PR

mandrenguyen avatar Oct 31 '24 20:10 mandrenguyen