cms-sw
[14.0.X] Generalize warp size in pixel clustering kernel
PR description:
In the FindClus kernel there was an assumption on the warp size being equal to 32, which is true for NVIDIA GPUs, but not always for AMD GPUs. Now the warp size is taken from the __AMDGCN_WAVEFRONT_SIZE macro for HIP and uses 32 for CUDA.
Note that alpaka::warp::getSize(acc) cannot be used because it's evaluated at runtime.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
backport of #46426
FYI @fwyzard
A new Pull Request was created by @AuroraPerego for CMSSW_14_0_X.
It involves the following packages:
- RecoLocalTracker/SiPixelClusterizer (reconstruction)
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @VinInn, @VourMa, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
- Backported from #46426
-1
Failed Tests: RelVals
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38a25e/42308/summary.html
COMMIT: e1ae84cc413d3b180d9049864b58d0426d85b2c5
CMSSW: CMSSW_14_0_X_2024-10-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46443/42308/install.sh to create a dev area with all the needed externals and cmssw changes.
RelVals
The relvals timed out after 4 hours.
+1
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38a25e/42315/summary.html
COMMIT: e1ae84cc413d3b180d9049864b58d0426d85b2c5
CMSSW: CMSSW_14_0_X_2024-10-20-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46443/42315/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 26 lines to the logs
- Reco comparison results: 86 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3349412
- DQMHistoTests: Total failures: 2340
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3347052
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
