cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

[LLVM Analyzer] Cleanup analyzer warnings

Open iarspider opened this issue 1 year ago • 29 comments

PR description:

See report.

PR validation:

Bot tests

iarspider avatar Oct 17 '24 12:10 iarspider

cms-bot internal usage

cmsbuild avatar Oct 17 '24 12:10 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42280

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42280/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42280/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 17 '24 12:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42281

cmsbuild avatar Oct 17 '24 12:10 cmsbuild

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DataFormats/DTRecHit (reconstruction)
  • DataFormats/GeometryCommonDetAlgo (simulation)
  • EventFilter/Utilities (daq)
  • FWCore/Framework (core)
  • FWCore/Services (core)
  • FastSimulation/CaloGeometryTools (fastsim)
  • HLTrigger/JetMET (hlt)

@Dr15Jones, @Martin-Grunewald, @civanch, @cmsbuild, @emeschi, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar, @ssekmen can you please review it and eventually sign? Thanks. @CeliaFernandez, @Fedespring, @HuguesBrun, @Martin-Grunewald, @ReyerBand, @abbiendi, @andrea21z, @battibass, @cericeci, @fwyzard, @jhgoh, @makortel, @matt-komm, @missirol, @mmusich, @rovere, @sbein, @silviodonato, @thomreis, @trocino, @wang0jin, @wddgit this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 17 '24 12:10 cmsbuild

please test

iarspider avatar Oct 17 '24 12:10 iarspider

@iarspider , I was thinking that instead of using assert(condition) why not use

#ifdef __clang_analyzer__
assert(condition);
#endif

This will silence the clang analyzer warning without adding the actual assert() for normal build. @makortel what do you think. Ofcourse we should add assert only on those places where we get false positives from clang analyzer

edited: for false positives, it is better to use [[clang::suppress]]

smuzaffar avatar Oct 17 '24 12:10 smuzaffar

-1

Failed Tests: Build HeaderConsistency ClangBuild Size: This PR adds an extra 64KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193333/42269/summary.html COMMIT: 84e760106cdd1e292cad0bb21aa2d8ead571348a CMSSW: CMSSW_14_2_X_2024-10-16-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46421/42269/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @bsunanda cms-sw/cmssw#46404

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193333/42269/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193333/42269/git-merge-result

Build

I found compilation error when building:

>> Compiling  src/FastSimulation/CaloGeometryTools/src/BaseCrystal.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_14_2_X_2024-10-16-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_2_X_2024-10-16-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-16-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-484c499dc51e2646f152cf0149808593/include/LCG -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/dd4hep/v01-29-00-f595e98759e21600901a749c6dd8f4e2/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/boost/1.80.0-477823d53efabc5118f199265eb7ab49/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/clhep/2.4.7.1-17c7283747b6cbc68a3534cb987a890c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/curl/7.79.0-abae79fca02c8e83ab0f428f2a91d96b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/gsl/2.6-4e597de26ced42091883404fa44cef2e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/lcg/root/6.30.09-c59d6b036f1cbd6988c172ba319259f1/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/tbb/v2021.9.0-e785b749a0b6cb9c66dc1d78066210e0/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/fmt/10.2.1-deba157dd76fed17ac8b42adc60ff53f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/OpenBLAS/0.3.27-6574458f8642b299ac965c654e194a8b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/tinyxml2/6.2.0-68d511689c5dbd9a0d296bbb795fa052/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/FastSimulation/CaloGeometryTools/src/FastSimulationCaloGeometryTools/BaseCrystal.cc.d src/FastSimulation/CaloGeometryTools/src/BaseCrystal.cc -o tmp/el8_amd64_gcc12/src/FastSimulation/CaloGeometryTools/src/FastSimulationCaloGeometryTools/BaseCrystal.cc.o
>> Compiling  src/FastSimulation/CaloGeometryTools/src/CaloDirectionOperations.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_14_2_X_2024-10-16-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_2_X_2024-10-16-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-16-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-484c499dc51e2646f152cf0149808593/include/LCG -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/dd4hep/v01-29-00-f595e98759e21600901a749c6dd8f4e2/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/boost/1.80.0-477823d53efabc5118f199265eb7ab49/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/clhep/2.4.7.1-17c7283747b6cbc68a3534cb987a890c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/curl/7.79.0-abae79fca02c8e83ab0f428f2a91d96b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/gsl/2.6-4e597de26ced42091883404fa44cef2e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/lcg/root/6.30.09-c59d6b036f1cbd6988c172ba319259f1/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/tbb/v2021.9.0-e785b749a0b6cb9c66dc1d78066210e0/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/fmt/10.2.1-deba157dd76fed17ac8b42adc60ff53f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/OpenBLAS/0.3.27-6574458f8642b299ac965c654e194a8b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/external/tinyxml2/6.2.0-68d511689c5dbd9a0d296bbb795fa052/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/FastSimulation/CaloGeometryTools/src/FastSimulationCaloGeometryTools/CaloDirectionOperations.cc.d src/FastSimulation/CaloGeometryTools/src/CaloDirectionOperations.cc -o tmp/el8_amd64_gcc12/src/FastSimulation/CaloGeometryTools/src/FastSimulationCaloGeometryTools/CaloDirectionOperations.cc.o
src/FastSimulation/CaloGeometryTools/src/CaloDirectionOperations.cc: In static member function 'static CaloDirection CaloDirectionOperations::add2d(const CaloDirection&, const CaloDirection&)':
src/FastSimulation/CaloGeometryTools/src/CaloDirectionOperations.cc:6:3: error: 'assert' was not declared in this scope
    6 |   assert(d1 != 999);
      |   ^~~~~~
src/FastSimulation/CaloGeometryTools/src/CaloDirectionOperations.cc:2:1: note: 'assert' is defined in header ''; did you forget to '#include '?
    1 | #include "FastSimulation/CaloGeometryTools/interface/CaloDirectionOperations.h"
  +++ |+#include

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'


>> Entering Package FWCore/Services
>> Entering Package FastSimulation/CaloGeometryTools
>> Entering Package Geometry/ForwardGeometry
>> Entering Package HLTrigger/JetMET
>> Compile sequence completed for CMSSW CMSSW_14_2_X_2024-10-16-2300
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_2_X_2024-10-16-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package DataFormats/DTRecHit
Entering library rule at DataFormats/DTRecHit
>> Compiling  src/DataFormats/DTRecHit/src/DTChamberRecSegment2D.cc

cmsbuild avatar Oct 17 '24 13:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42284

cmsbuild avatar Oct 17 '24 13:10 cmsbuild

Pull request #46421 was updated. @Dr15Jones, @Martin-Grunewald, @civanch, @cmsbuild, @emeschi, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar, @ssekmen can you please check and sign again.

cmsbuild avatar Oct 17 '24 13:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42285

cmsbuild avatar Oct 17 '24 13:10 cmsbuild

Pull request #46421 was updated. @Dr15Jones, @Martin-Grunewald, @civanch, @cmsbuild, @emeschi, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar, @ssekmen can you please check and sign again.

cmsbuild avatar Oct 17 '24 13:10 cmsbuild

please test

iarspider avatar Oct 17 '24 14:10 iarspider

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn Size: This PR adds an extra 36KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193333/42272/summary.html COMMIT: aab4fe5d2d065a18ff8deff6db6e4a0a8da666ee CMSSW: CMSSW_14_2_X_2024-10-16-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46421/42272/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @bsunanda cms-sw/cmssw#46404

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193333/42272/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193333/42272/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_22_setup had ERRORS
---> test testDriftTimeParam had ERRORS
and more ...

RelVals

The relvals timed out after 4 hours.

  • 5.1A fatal system signal has occurred: abort signal
  • 7.3A fatal system signal has occurred: abort signal
  • 9.0A fatal system signal has occurred: abort signal
Expand to see more relval errors ...

RelVals-INPUT

  • 2022.1010012022.101001_RunEGamma2022C_10k/step1_dasquery.log
  • 2023.0010012023.001001_RunDisplacedJet2023C_10k/step1_dasquery.log
  • 11024.211024.2_TTbar_13UP18HEfailINPUT/step2_TTbar_13UP18HEfailINPUT.log
Expand to see more relval errors ...
  • 2022.101001
  • 2023.001001

AddOn Tests

A fatal system signal has occurred: abort signal

A fatal system signal has occurred: abort signal

A fatal system signal has occurred: abort signal
Expand to see more addon errors ...

cmsbuild avatar Oct 17 '24 19:10 cmsbuild

please test

iarspider avatar Oct 17 '24 20:10 iarspider

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42294

cmsbuild avatar Oct 17 '24 20:10 cmsbuild

Pull request #46421 was updated. @Dr15Jones, @Martin-Grunewald, @civanch, @emeschi, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar, @ssekmen can you please check and sign again.

cmsbuild avatar Oct 17 '24 20:10 cmsbuild

+1

Size: This PR adds an extra 40KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193333/42280/summary.html COMMIT: 0985e765e84c1d73600ba566e519f0469b5e0088 CMSSW: CMSSW_14_2_X_2024-10-17-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46421/42280/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3335129
  • DQMHistoTests: Total failures: 452
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3334657
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 18 '24 01:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42305

cmsbuild avatar Oct 18 '24 14:10 cmsbuild

Pull request #46421 was updated. @Dr15Jones, @Martin-Grunewald, @civanch, @cmsbuild, @emeschi, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar, @ssekmen can you please check and sign again.

cmsbuild avatar Oct 18 '24 14:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42309

cmsbuild avatar Oct 18 '24 21:10 cmsbuild

Pull request #46421 was updated. @Dr15Jones, @Martin-Grunewald, @civanch, @cmsbuild, @emeschi, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar, @ssekmen can you please check and sign again.

cmsbuild avatar Oct 18 '24 21:10 cmsbuild

please test

iarspider avatar Oct 18 '24 21:10 iarspider

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46421/42310

cmsbuild avatar Oct 18 '24 21:10 cmsbuild

Pull request #46421 was updated. @Dr15Jones, @Martin-Grunewald, @civanch, @emeschi, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar can you please check and sign again.

cmsbuild avatar Oct 18 '24 21:10 cmsbuild

+1

Size: This PR adds an extra 48KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-193333/42303/summary.html COMMIT: 6b495a054cf4fb44391954929e60049822079142 CMSSW: CMSSW_14_2_X_2024-10-18-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46421/42303/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566331
  • DQMHistoTests: Total failures: 516
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565795
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 19 '24 01:10 cmsbuild

+1

jfernan2 avatar Oct 19 '24 21:10 jfernan2

+1

smorovic avatar Oct 19 '24 21:10 smorovic

+1

civanch avatar Oct 21 '24 18:10 civanch

+core

makortel avatar Oct 21 '24 19:10 makortel

+hlt

mmusich avatar Oct 28 '24 04:10 mmusich