cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[LLVM Analyzer][Generators] Cleanup LLVM analyzer warnings

Open iarspider opened this issue 1 year ago • 10 comments

PR description:

See report

PR validation:

Bot tests

iarspider avatar Oct 16 '24 11:10 iarspider

please test

iarspider avatar Oct 16 '24 11:10 iarspider

cms-bot internal usage

cmsbuild avatar Oct 16 '24 11:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46402/42252

cmsbuild avatar Oct 16 '24 11:10 cmsbuild

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • GeneratorInterface/EvtGenInterface (generators)
  • GeneratorInterface/RivetInterface (generators)

@bbilin, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 16 '24 11:10 cmsbuild

please abort

iarspider avatar Oct 16 '24 11:10 iarspider

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46402/42253

cmsbuild avatar Oct 16 '24 11:10 cmsbuild

Pull request #46402 was updated. @bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please check and sign again.

cmsbuild avatar Oct 16 '24 11:10 cmsbuild

please test

iarspider avatar Oct 16 '24 11:10 iarspider

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d93cbf/42232/summary.html COMMIT: e06f9aecefb28f319e5b362d5d5b80d33dadb46d CMSSW: CMSSW_14_2_X_2024-10-15-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46402/42232/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @bsunanda cms-sw/cmssw#46386

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d93cbf/42232/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d93cbf/42232/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

  • 2024.1010012024.101001_RunZeroBias2024C_10k/step1_dasquery.log

Comparison Summary

Summary:

cmsbuild avatar Oct 16 '24 16:10 cmsbuild

@cmsbuild ignore tests-rejected with external-failure

iarspider avatar Oct 17 '24 11:10 iarspider

@cms-sw/generators-l2 gentle ping

iarspider avatar Nov 04 '24 20:11 iarspider

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

cmsbuild avatar Nov 22 '24 13:11 cmsbuild

@cmsbuild please test

iarspider avatar Nov 27 '24 14:11 iarspider

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d93cbf/43111/summary.html COMMIT: e06f9aecefb28f319e5b362d5d5b80d33dadb46d CMSSW: CMSSW_15_0_X_2024-11-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46402/43111/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 510
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3483192
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

cmsbuild avatar Nov 27 '24 16:11 cmsbuild

+1

lviliani avatar Nov 27 '24 17:11 lviliani

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Nov 27 '24 17:11 cmsbuild

+1

mandrenguyen avatar Nov 27 '24 19:11 mandrenguyen