cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Fix qBin iteration in PixelCPEFastParamsHost.cc

Open mroguljic opened this issue 1 year ago • 36 comments

PR description:

Fix for this issue: https://github.com/cms-sw/cmssw/issues/46383 The loop for filling template info for different qBins now checks if any are skipped instead of relying on small fixed increments to prevent this. If a qBin is skipped, fill its content with the value from the neighboring, lower-charged qBin

PR validation:

Validation in progress

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport

Ran checks on: 29634.402

29634.402_TTbar_14TeV+2026D110_Patatrack_PixelOnlyAlpaka Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 15 17:40:17 2024-date Tue Oct 15 17:26:23 2024; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

mroguljic avatar Oct 15 '24 14:10 mroguljic

cms-bot internal usage

cmsbuild avatar Oct 15 '24 14:10 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42237

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42237/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42237/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 15 '24 14:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42238

cmsbuild avatar Oct 15 '24 14:10 cmsbuild

A new Pull Request was created by @mroguljic for master.

It involves the following packages:

  • RecoLocalTracker/SiPixelRecHits (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @VinInn, @VourMa, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 15 '24 14:10 cmsbuild

fixes https://github.com/cms-sw/cmssw/issues/46383

jfernan2 avatar Oct 15 '24 14:10 jfernan2

test parameters:

  • workflow =29634.402

smuzaffar avatar Oct 15 '24 14:10 smuzaffar

please test

smuzaffar avatar Oct 15 '24 14:10 smuzaffar

please test for CMSSW_14_2_UBSAN_X

smuzaffar avatar Oct 15 '24 14:10 smuzaffar

please test for CMSSW_14_2_UBSAN_X

I just ran some local tests for 29634.402 and it seems to hang, will have to do further checks

mroguljic avatar Oct 15 '24 14:10 mroguljic

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42241

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42241/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42241/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 15 '24 15:10 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42243

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42243/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42243/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 15 '24 15:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42244

cmsbuild avatar Oct 15 '24 15:10 cmsbuild

Pull request #46392 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

cmsbuild avatar Oct 15 '24 15:10 cmsbuild

@smuzaffar I was able to run the wf locally. We can proceed with the tests.

mroguljic avatar Oct 15 '24 15:10 mroguljic

please test for CMSSW_14_2_UBSAN_X

smuzaffar avatar Oct 15 '24 16:10 smuzaffar

please test

smuzaffar avatar Oct 15 '24 16:10 smuzaffar

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b6aa4/42213/summary.html COMMIT: 6e661734c9bf09346a960dc4730b24b23944a9f5 CMSSW: CMSSW_14_2_X_2024-10-15-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46392/42213/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3350742
  • DQMHistoTests: Total failures: 4271
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346451
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 197 log files, 167 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 15 '24 21:10 cmsbuild

enable hlt_p2_timing

mmusich avatar Oct 15 '24 21:10 mmusich

@cmsbuild, please test

mmusich avatar Oct 15 '24 21:10 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b6aa4/42212/summary.html COMMIT: 6e661734c9bf09346a960dc4730b24b23944a9f5 CMSSW: CMSSW_14_2_UBSAN_X_2024-10-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46392/42212/install.sh to create a dev area with all the needed externals and cmssw changes.

cmsbuild avatar Oct 15 '24 21:10 cmsbuild

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b6aa4/42222/summary.html COMMIT: 6e661734c9bf09346a960dc4730b24b23944a9f5 CMSSW: CMSSW_14_2_X_2024-10-15-1400/el8_amd64_gcc12 Additional Tests: HLT_P2_TIMING User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46392/42222/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Oct 16 '24 01:10 cmsbuild

thanks @mroguljic , I confirm that ubsan runtime errors are fixed now

smuzaffar avatar Oct 16 '24 05:10 smuzaffar

HLT P2 Timing: chart

Phase HLT timing is suggestive of a visible increase though.

mmusich avatar Oct 16 '24 05:10 mmusich

assign heterogeneous

mmusich avatar Oct 16 '24 05:10 mmusich

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Oct 16 '24 05:10 cmsbuild

@mroguljic could you squash all commits into one ?

fwyzard avatar Oct 16 '24 06:10 fwyzard

I don't have any comments from the @cms-sw/heterogeneous-l2 side. If there is a potential impact on the performance, can it be tested on the Run 3 HLT using the usual timing server ?

fwyzard avatar Oct 16 '24 06:10 fwyzard

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46392/42249

cmsbuild avatar Oct 16 '24 06:10 cmsbuild

Pull request #46392 was updated. @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please check and sign again.

cmsbuild avatar Oct 16 '24 06:10 cmsbuild

please test

smuzaffar avatar Oct 16 '24 12:10 smuzaffar