cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

[LLVM Analyzer][DQM] Fix LLVM analyzer warnings

Open iarspider opened this issue 1 year ago • 31 comments

PR description:

Reports: link

PR validation:

Bot tests

iarspider avatar Oct 11 '24 12:10 iarspider

please test

iarspider avatar Oct 11 '24 12:10 iarspider

cms-bot internal usage

cmsbuild avatar Oct 11 '24 12:10 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42184

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DQMOffline/Hcal/src/HcalRecHitsDQMClient.cc modified in PR(s): #46247

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42184/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42184/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 11 '24 12:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42185

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DQMOffline/Hcal/src/HcalRecHitsDQMClient.cc modified in PR(s): #46247

cmsbuild avatar Oct 11 '24 12:10 cmsbuild

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • CommonTools/TrackerMap (dqm, reconstruction)
  • DQM/CastorMonitor (dqm)
  • DQM/DTMonitorModule (dqm)
  • DQM/EcalCommon (dqm)
  • DQM/EcalMonitorTasks (dqm)
  • DQM/SiPixelMonitorClient (dqm)
  • DQM/SiStripMonitorClient (dqm)
  • DQM/SiStripMonitorHardware (dqm)
  • DQMOffline/Hcal (dqm)
  • DQMOffline/Muon (dqm)
  • DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @jfernan2, @mandrenguyen, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. @Fedespring, @HuguesBrun, @ReyerBand, @abbiendi, @abdoulline, @argiro, @arossi83, @barvic, @battibass, @bellan, @bsunanda, @calderona, @cericeci, @denizsun, @fioriNTU, @idebruyn, @jandrea, @jhgoh, @missirol, @mmusich, @mtosi, @ptcox, @rchatter, @rociovilar, @salimcerci, @sroychow, @thomreis, @threus, @trocino, @venturia, @wang0jin this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 11 '24 12:10 cmsbuild

please test

iarspider avatar Oct 11 '24 12:10 iarspider

-1

Failed Tests: RelVals RelVals-INPUT Size: This PR adds an extra 108KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82d36e/42128/summary.html COMMIT: de5632ea1d0563b8a9cd26f1eb118a23f957b296 CMSSW: CMSSW_14_2_X_2024-10-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46354/42128/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 9.0A fatal system signal has occurred: abort signal
  • 25.0A fatal system signal has occurred: abort signal
  • 1306.0A fatal system signal has occurred: abort signal
Expand to see more relval errors ...

RelVals-INPUT

  • 2022.1000012022.100001_RunJetHT2022C_10k/step1_dasquery.log
  • 2022.100001DAS Error

cmsbuild avatar Oct 11 '24 14:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42193

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DQMOffline/Hcal/src/HcalRecHitsDQMClient.cc modified in PR(s): #46247

cmsbuild avatar Oct 11 '24 14:10 cmsbuild

Pull request #46354 was updated. @antoniovagnerini, @cmsbuild, @jfernan2, @mandrenguyen, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild avatar Oct 11 '24 14:10 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42194

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DQMOffline/Hcal/src/HcalRecHitsDQMClient.cc modified in PR(s): #46247

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42194/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42194/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 11 '24 15:10 cmsbuild

please test

iarspider avatar Oct 11 '24 15:10 iarspider

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42195

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DQMOffline/Hcal/src/HcalRecHitsDQMClient.cc modified in PR(s): #46247

cmsbuild avatar Oct 11 '24 15:10 cmsbuild

Pull request #46354 was updated. @antoniovagnerini, @jfernan2, @mandrenguyen, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild avatar Oct 11 '24 15:10 cmsbuild

+1

Size: This PR adds an extra 28KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82d36e/42136/summary.html COMMIT: 818189cd1681f410fe6933a7878d26582669727b CMSSW: CMSSW_14_2_X_2024-10-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46354/42136/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Oct 11 '24 19:10 cmsbuild

+1 For the RECO part

jfernan2 avatar Oct 14 '24 08:10 jfernan2

hold I think dqm change https://github.com/cms-sw/cmssw/pull/46354/files#diff-b05c6c3040b7b39d74c1d31a462081674e438b271ffa936aea9ed7ebc41a642cR168 needs better understanding

smuzaffar avatar Oct 14 '24 08:10 smuzaffar

Pull request has been put on hold by @smuzaffar They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar Oct 14 '24 08:10 cmsbuild

please test

iarspider avatar Oct 16 '24 08:10 iarspider

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42250

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DQMOffline/Hcal/src/HcalRecHitsDQMClient.cc modified in PR(s): #46247

cmsbuild avatar Oct 16 '24 08:10 cmsbuild

Pull request #46354 was updated. @antoniovagnerini, @jfernan2, @mandrenguyen, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild avatar Oct 16 '24 08:10 cmsbuild

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82d36e/42227/summary.html COMMIT: 47cf84b7145e5221edd75781ec0ea3294753b1a0 CMSSW: CMSSW_14_2_X_2024-10-15-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46354/42227/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Oct 16 '24 11:10 cmsbuild

Dead code warnings are fixed in a separate PR https://github.com/cms-sw/cmssw/pull/46247 .

iarspider avatar Oct 18 '24 11:10 iarspider

please test

iarspider avatar Oct 18 '24 11:10 iarspider

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46354/42300

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DQMOffline/Hcal/src/HcalRecHitsDQMClient.cc modified in PR(s): #46247

cmsbuild avatar Oct 18 '24 11:10 cmsbuild

Pull request #46354 was updated. @antoniovagnerini, @jfernan2, @mandrenguyen, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild avatar Oct 18 '24 11:10 cmsbuild

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 48KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82d36e/42296/summary.html COMMIT: 6d52560bb4abd563d74e3e8e90bfa9bcdf2a7b8e CMSSW: CMSSW_14_2_X_2024-10-17-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46354/42296/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
  • 2024.000001DAS Error

Comparison Summary

Summary:

cmsbuild avatar Oct 18 '24 14:10 cmsbuild

please test

antoniovagnerini avatar Oct 20 '24 07:10 antoniovagnerini

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82d36e/42310/summary.html COMMIT: 6d52560bb4abd563d74e3e8e90bfa9bcdf2a7b8e CMSSW: CMSSW_14_2_X_2024-10-20-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46354/42310/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566331
  • DQMHistoTests: Total failures: 486
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565825
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 20 '24 14:10 cmsbuild

+1 For the reco part

jfernan2 avatar Oct 21 '24 08:10 jfernan2

@cms-sw/dqm-l2 could you please review? @smuzaffar could you please unhold - the question was discussed and resolved link

iarspider avatar Oct 23 '24 12:10 iarspider