cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

FastSim premixing workflows and matrix cleanup [14_0_X]

Open kpedro88 opened this issue 1 year ago • 19 comments

backport of #46007

kpedro88 avatar Sep 16 '24 14:09 kpedro88

A new Pull Request was created by @kpedro88 for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

  • Backported from #46007

cmsbuild avatar Sep 16 '24 14:09 cmsbuild

cms-bot internal usage

cmsbuild avatar Sep 16 '24 14:09 cmsbuild

test parameters: workflow = 13461.97,13434.99 relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

kpedro88 avatar Sep 16 '24 14:09 kpedro88

please test

kpedro88 avatar Sep 16 '24 14:09 kpedro88

+1

Size: This PR adds an extra 36KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-538038/41540/summary.html COMMIT: 4edb8909e3b3288cd192375ebdd7d12a6eb78e5e CMSSW: CMSSW_14_0_X_2024-09-16-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46008/41540/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 191 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1412 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3398683
  • DQMHistoTests: Total failures: 5116
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3393547
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 168 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Sep 16 '24 17:09 cmsbuild

Pull request #46008 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

cmsbuild avatar Sep 27 '24 19:09 cmsbuild

please test

kpedro88 avatar Sep 27 '24 19:09 kpedro88

+1

Size: This PR adds an extra 36KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-538038/41791/summary.html COMMIT: 40b15161fce65482b6ce6217d9208ba8d5abeda7 CMSSW: CMSSW_14_0_X_2024-09-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46008/41791/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1393 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3400982
  • DQMHistoTests: Total failures: 3901
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3397061
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 168 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Sep 27 '24 22:09 cmsbuild

Pull request #46008 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

cmsbuild avatar Oct 01 '24 20:10 cmsbuild

please test

kpedro88 avatar Oct 02 '24 13:10 kpedro88

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-538038/41887/summary.html COMMIT: d616785330973d447f43c5bd98989da6015ba187 CMSSW: CMSSW_14_0_X_2024-10-02-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46008/41887/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 98 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1416 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3400982
  • DQMHistoTests: Total failures: 3604
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3397358
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 168 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 02 '24 17:10 cmsbuild

+pdmv

AdrianoDee avatar Oct 02 '24 17:10 AdrianoDee

@cms-sw/upgrade-l2 please sign

kpedro88 avatar Oct 10 '24 14:10 kpedro88

Kindly ping @cms-sw/upgrade-l2

srimanob avatar Oct 14 '24 10:10 srimanob

+Upgrade

Moanwar avatar Oct 14 '24 10:10 Moanwar

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 14 '24 10:10 cmsbuild

hold is this needed for 14_0_X at this point?

mandrenguyen avatar Oct 16 '24 06:10 mandrenguyen

Pull request has been put on hold by @mandrenguyen They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar Oct 16 '24 06:10 cmsbuild

Yes, this is needed in 14_0_X:

  1. This workflow in this release was used for the CDR profiling. It should be reproducible in the future without manually merging branches/PRs.
  2. We anticipate possible Run 3 FastSim production in this release.

kpedro88 avatar Oct 16 '24 12:10 kpedro88

unhold

antoniovilela avatar Nov 07 '24 20:11 antoniovilela

please test

antoniovilela avatar Nov 07 '24 20:11 antoniovilela

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Nov 07 '24 20:11 cmsbuild

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-538038/42669/summary.html COMMIT: d616785330973d447f43c5bd98989da6015ba187 CMSSW: CMSSW_14_0_X_2024-11-07-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46008/42669/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 79 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1433 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3401258
  • DQMHistoTests: Total failures: 6811
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3394427
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 168 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Nov 08 '24 01:11 cmsbuild

+1

antoniovilela avatar Nov 11 '24 15:11 antoniovilela