cms-sw
Clean up Phase-2 Geometry D86, D88, D91, D92, D93, D94, D97
PR description:
This PR follows the issue https://github.com/cms-sw/cmssw/issues/43251 to clean up all geometries with I14 and I15. With this PR, T24, T25, T30, I14, I15, O8 become unused geometries. They are in the list of obsolete subdetectors.
We will need a follow up PR, to introduce new geometry with HFNose to replace D94.
FYI @cms-sw/mtd-dpg-l2 @cms-sw/geometry-l2 @cms-sw/trk-dpg-l2 @emiglior @cms-sw/l1-l2
PR validation:
Try to dump D95, D110 config. runTheMatrix gives the proper config files.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No need of backport.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45370/40803
-
This PR adds an extra 64KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_2026.py modified in PR(s): #45117
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #45117, #45333
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): #45240
A new Pull Request was created by @srimanob for master.
It involves the following packages:
- Configuration/Geometry (geometry, upgrade)
- Configuration/PyReleaseValidation (pdmv, upgrade)
- Configuration/StandardSequences (operations)
- Geometry/CMSCommonData (geometry, upgrade)
@AdrianoDee, @Dr15Jones, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kskovpen, @makortel, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @bsunanda, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo, @vargasa this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8685c7/40204/summary.html
COMMIT: 905735877c0eac8fd750fded8d7c5d39ed258b59
CMSSW: CMSSW_14_1_X_2024-07-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45370/40204/install.sh to create a dev area with all the needed externals and cmssw changes.
- DAS Queries: The DAS query tests failed, see the summary page for details.
Comparison Summary
There are some workflows for which there are errors in the baseline: 29634.911 step 2 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request
Summary:
- You potentially removed 25 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 3 differences found in the comparisons
- DQMHistoTests: Total files compared: 46
- DQMHistoTests: Total histograms compared: 3148602
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3148579
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
- Checked 194 log files, 159 edm output root files, 46 DQM output files
- TriggerResults: no differences found
Hi @bsunanda
It would be great if you can provide the timeline of your comment in https://github.com/cms-sw/cmssw/issues/43251#issuecomment-2049490514 ? You mentioned that "Also we need to keep a scenario with C20. If D94 is to be deleted we have to create one with C20 as D111". I also mention in the description of this PR that we need that, I did not ignore the request, but no timeline provided on geometry side.
Is it straightforward to create new geometry with C20? The goal of the cleanup is to completely remove geometry with I14 and I15.
Thx.
Please do not make that one. I am making one myself. I am committing it now
From: Phat Srimanobhas @.> Sent: 04 July 2024 16:01 To: cms-sw/cmssw @.> Cc: Sunanda Banerjee @.>; Mention @.> Subject: Re: [cms-sw/cmssw] Clean up Phase-2 Geometry D86, D88, D91, D92, D93, D94, D97 (PR #45370)
I make a draft PRhttps://github.com/cms-sw/cmssw/pull/45372 of D115 which is D110 with C20 (C18+HFNose)
— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/45370#issuecomment-2208646598, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGMZOQXNYNIRYSWG6JZNYDZKUQA7AVCNFSM6AAAAABKKBBSA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYGY2DMNJZHA. You are receiving this because you were mentioned.Message ID: @.***>
Phase2-gde179 Make a new scenario 2026D115 and workflow 32034.0 for a setup with HFNose and V17 geometry version of HGCal #45375
Thanks @bsunanda
Pull request has been put on hold by @srimanob
They need to issue an unhold command to remove the hold state or L1 can unhold it for all
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45370/40821
- There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): #45375
- File Configuration/PyReleaseValidation/python/relval_2026.py modified in PR(s): #45117, #45375
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #45117, #45333, #45368, #45375
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): #45240
- File Configuration/StandardSequences/python/GeometryConf.py modified in PR(s): #45375
Pull request #45370 was updated. @AdrianoDee, @Dr15Jones, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kskovpen, @makortel, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.
I was thinking, shall we keep the geometries that have been used as baseline for a while and have been used for major productions?
I'm thinking of D88 in this context. I'm asking this since, for example, I remember that at the time of the HLT Phase2 TDR we used D49 and then we couldn't have a fair comparison between what we documented there and what was developed in the months after (being in a newer release were D49 was dropped).
I was thinking, shall we keep the geometries that have been used as baseline for a while and have been used for major productions?
I'm thinking of D88 in this context. I'm asking this since, for example, I remember that at the time of the HLT Phase2 TDR we used D49 and then we couldn't have a fair comparison between what we documented there and what was developed in the months after (being in a newer release were D49 was dropped).
The cleaning has a reason behind. Keeping old geometry means we need to keep code related to that geometry also. This will us pay more price, because new code will come with more complicated structure, something may change in between, i.e. detID. See https://github.com/cms-sw/cmssw/issues/43251#issuecomment-2199591820
What HLT was used before in Phase2 2023 campaign, it is still there, no deletion. L1T needs to move from older campaign, so we keep 14_0 in case they need to go back.
The cleaning has a reason behind. Keeping old geometry means we need to keep code related to that geometry also. This will us pay more price, because new code will come with more complicated structure, something may change in between, i.e. detID. See https://github.com/cms-sw/cmssw/issues/43251#issuecomment-2199591820
I see, understood: maintainability
+1
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8685c7/40927/summary.html
COMMIT: 423797ed5ecca570715e63a2cd355db04e457aca
CMSSW: CMSSW_14_1_X_2024-08-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45370/40927/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 9 differences found in the comparisons
- DQMHistoTests: Total files compared: 44
- DQMHistoTests: Total histograms compared: 3324476
- DQMHistoTests: Total failures: 12
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3324444
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
- Checked 191 log files, 161 edm output root files, 44 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.
@srimanob after this PR a bunch of unit tests relying on deprecated geometries have started to fail, see logs. For next clean-up a full cmssw test would be commendable.
@srimanob after this PR a bunch of unit tests relying on deprecated geometries have started to fail, see logs. For next clean-up a full cmssw test would be commendable.
Thx Marco. Sorry for that. I have on my list to update the placeholder of geometry, but I have not managed it.
Sorry for that. I have on my list to update the placeholder of geometry, but I have not managed it.
No problem, I can give it a try.