cms-sw
Phase2-hgx358C Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal
PR description:
Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal
PR validation:
Use the runTheMatrix test workflow
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40790
- This PR adds an extra 92KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
- code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40790/code-format.patch
e.g.
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40790/code-format.patch | patch -p1You can also runscram build code-formatto apply code format directly
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40791
- This PR adds an extra 92KB to repository
A new Pull Request was created by @bsunanda for master.
It involves the following packages:
- Geometry/HGCalCommonData (geometry, upgrade)
- Geometry/HGCalGeometry (geometry, upgrade)
- SimCalorimetry/HGCalSimAlgos (simulation, upgrade)
- SimG4CMS/Calo (simulation)
- Validation/HGCalValidation (dqm)
@Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. @ReyerBand, @apsallid, @cseez, @fabiocos, @felicepantaleo, @hatakeyamak, @lecriste, @lgray, @martinamalberti, @missirol, @pfs, @rovere, @sameasy, @sethzenz, @slomeo, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40793
- This PR adds an extra 96KB to repository
Pull request #45366 was updated. @Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21ee98/40197/summary.html
COMMIT: 0f76b006a3eca31fd1efbbe05cfc2eb1fb1f5ccb
CMSSW: CMSSW_14_1_X_2024-07-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45366/40197/install.sh to create a dev area with all the needed externals and cmssw changes.
- DAS Queries: The DAS query tests failed, see the summary page for details.
Comparison Summary
Summary:
- You potentially added 6 lines to the logs
- Reco comparison results: 4047 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3345088
- DQMHistoTests: Total failures: 5390
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3339678
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: found differences in 2 / 46 workflows
Note for the next PR:
src/SimCalorimetry/HGCalSimAlgos/src/HGCalSciNoiseMap.cc:167:10: warning: Value stored to 'edge' during its initialization is never read [deadcode.DeadStores]
167 | double edge(refEdge_); //start with reference 3cm of edge
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
