cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Phase2-hgx358B Modify the name of the class HGCPassive to HGCalTBPassive to separate the names of TB and non-TB classes of HGCal

Open bsunanda opened this issue 1 year ago • 7 comments

PR description:

Modify the name of the class HGCPassive to HGCalTBPassive to separate the names of TB and non-TB classes of HGCal

PR validation:

Tested using one of the scripts in the test area of SimG4CMS/HGCalTestBeam

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar Jul 03 '24 06:07 bsunanda

cms-bot internal usage

cmsbuild avatar Jul 03 '24 06:07 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45365/40788

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45365/40788/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45365/40788/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Jul 03 '24 06:07 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45365/40789

  • This PR adds an extra 24KB to repository

cmsbuild avatar Jul 03 '24 06:07 cmsbuild

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/HGCalTBCommonData (geometry)
  • SimG4CMS/HGCalTestBeam (upgrade, simulation)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jul 03 '24 06:07 cmsbuild

@cmsbuild Please test

bsunanda avatar Jul 03 '24 07:07 bsunanda

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3db15e/40193/summary.html COMMIT: 78782ce4e0c14c2974bf2ff88fdc62bc9615ff2e CMSSW: CMSSW_14_1_X_2024-07-02-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45365/40193/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345068
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 03 '24 10:07 cmsbuild

+1

civanch avatar Jul 03 '24 12:07 civanch

+Upgrade

srimanob avatar Jul 08 '24 21:07 srimanob

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 08 '24 21:07 cmsbuild

+1

antoniovilela avatar Jul 08 '24 22:07 antoniovilela