cms-sw
Phase2-hgx358A Fix a bug in the conversion code for HGCal scintillator xml files
PR description:
Fix a bug in the conversion code for HGCal scintillator XML files. The results from the conversion code are to be combined with the results from PR #45354
PR validation:
Obtained a new set of XML files to be combined with the new silicon files once the PR #45354 is merged
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45364/40787
- This PR adds an extra 28KB to repository
A new Pull Request was created by @bsunanda for master.
It involves the following packages:
- Geometry/HGCalCommonData (geometry, upgrade)
@Dr15Jones, @bsunanda, @civanch, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a95c0f/40191/summary.html
COMMIT: d7f8263e8a9fe4cca081f84abd06ad00f66c2eeb
CMSSW: CMSSW_14_1_X_2024-07-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45364/40191/install.sh to create a dev area with all the needed externals and cmssw changes.
- DAS Queries: The DAS query tests failed, see the summary page for details.
Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 711 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3345088
- DQMHistoTests: Total failures: 8304
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3336764
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
@bsunanda , in the description you write that this is the fix for conversion from XML but in reality you fix the test and not run time conversion. May be the description should be more precise?
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
