Improvements to HLT Validation

[Sam-Harper]

PR description:

This PR modifies the HLT basic validation code to better meet the needs of the HLT group. Currently none of this code is run centrally however it is intended to be added to validation workflows in the near future once we are happy the validation is exactly what we want.

It consists of a general code cleanup of the modules, the ability to plot masses, bug fixes where it wasnt working well with the current DQM system, addition of resolution plots, addition of hadronic taus and fixes to the config syntax to more easily make the plots.

It also adds customisations to add this to any config.

It is designed to work with https://cmshltvalidation.app.cern.ch which displays these results. It is intended to run a basic validation on demand which is somewhere between the usual runTheMatrix and PR tests and a full scale validation.

This was most recently presented at https://indico.cern.ch/event/1426780/contributions/6008585/attachments/2880267/5045796/cmshltvalidation.pdf

PR validation:

The plots in https://cmshltvalidation.app.cern.ch look as expected

This is still a draft PR and is not yet ready to be reviewed

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45355/40775

• This PR adds an extra 220KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/HLTrigger/plugins/HLTGenValSource.cc modified in PR(s): #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45355/40775/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45355/40775/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45355/40776

• This PR adds an extra 220KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/HLTrigger/plugins/HLTGenValSource.cc modified in PR(s): #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45355/40776/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45355/40776/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45355/40777

• This PR adds an extra 220KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/HLTrigger/plugins/HLTGenValSource.cc modified in PR(s): #44372

[cmsbuild]

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)
• Validation/HLTrigger (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. @Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @trocino this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[tjavaid]

@Sam-Harper , the PR is in draft mode; do we expect another commit or is it ready for a review ?

[Sam-Harper]

Still some more things coming

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[antoniovilela]

ping (to make bot change milestone)

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.