cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Phase2-hgx358 Modify the silicon part of the V19 version of HGCal geometry using the new flat file information

Open bsunanda opened this issue 1 year ago • 8 comments

PR description:

Modify the silicon part of the V19 version of HGCal geometry using the new flat file information

PR validation:

To be fully tested once the V19 geometry code becomes available

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar Jul 01 '24 14:07 bsunanda

cms-bot internal usage

cmsbuild avatar Jul 01 '24 14:07 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45354/40774

  • This PR adds an extra 96KB to repository

cmsbuild avatar Jul 01 '24 14:07 cmsbuild

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jul 01 '24 14:07 cmsbuild

@cmsbuild Please test

bsunanda avatar Jul 01 '24 15:07 bsunanda

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f67357/40174/summary.html COMMIT: 97baeaad0266759ee86693b828fe8b6574a28935 CMSSW: CMSSW_14_1_X_2024-07-01-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45354/40174/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345065
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 01 '24 18:07 cmsbuild

+1

civanch avatar Jul 02 '24 15:07 civanch

+Upgrade

srimanob avatar Jul 02 '24 18:07 srimanob

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 02 '24 18:07 cmsbuild

@antoniovilela, @rappoccio Please merge this PR

bsunanda avatar Jul 04 '24 08:07 bsunanda

+1

antoniovilela avatar Jul 04 '24 18:07 antoniovilela