cms-sw
Add 2024 L1T modifier & modifiers for changing BMTF quality calculation
PR description:
This PR adds an Era based modifier to the new BMTF quality calculation introduced by https://github.com/cms-sw/cmssw/pull/44432, to allow for use of the old versus new quality calculation in the planned upcoming re-reco + MC campaign. The default is to use the old calculation and for Run3_2024 Eras and beyond to use the new calculation.
As a note, this does introduce a modifier file I have created personally, I don't know if there is a standard for who can create these or when they should be made, and it is introduced to the Run3_2024 era.
@slaurila @eyigitba: FYI
PR validation:
All code compiles and has had formatting applied. The settings+flag has been tested in L1 re-emulation under different eras to trigger the correct quality calculation.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport and is not expected to be backported.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45352/40771
-
This PR adds an extra 36KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Run3_2024_cff.py modified in PR(s): #44970
A new Pull Request was created by @aloeliger for master.
It involves the following packages:
- Configuration/Eras (operations)
- L1Trigger/L1TMuonBarrel (l1)
@aloeliger, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @rappoccio can you please review it and eventually sign? Thanks. @AnnikaStein, @JanFSchulte, @Martin-Grunewald, @dinyar, @eyigitba, @fabiocos, @makortel, @missirol, @mmusich, @thomreis this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b955f/40177/summary.html
COMMIT: bc19415b33bf59f01661403dc455cd4b83928de9
CMSSW: CMSSW_14_1_X_2024-07-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45352/40177/install.sh to create a dev area with all the needed externals and cmssw changes.
- DAS Queries: The DAS query tests failed, see the summary page for details.
Comparison Summary
Summary:
- You potentially removed 5 lines from the logs
- Reco comparison results: 10 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3345088
- DQMHistoTests: Total failures: 246
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3344822
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.