cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

L1 Scouting Online Selection modules

Open Mmiglio opened this issue 1 year ago • 7 comments

PR description:

This PR introduces the modules used for the L1 Scouting Online selection, which will complement the "Zero bias" stream. The selection stream was discussed during L1 Trigger DPG meetings (e.g. link)

Related to this PR, a new category is introduced with https://github.com/cms-sw/cms-bot/pull/2276.

PR validation:

The PR has been validate using files collected in the "Zero Bias" stream, e.g.

cmsRun test/L1ScoutingSelector.py inFile=file:root://xrootd-cms.infn.it///store/data/Run2024F/L1Scouting/L1SCOUT/v1/000/382/580/00000/00c66a36-4a65-4b2a-a637-0b02629cb1da.root numOrbits=100 outFile=/tmp/dump.root

In parallel, it was successfully tested in the Scouting system at P5.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We would like this PR to be backported in a data-taking release (14_0_X) in order to collect data from pp collisions during 2024.

Mmiglio avatar Jul 01 '24 08:07 Mmiglio

cms-bot internal usage

cmsbuild avatar Jul 01 '24 08:07 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45350/40769

  • This PR adds an extra 24KB to repository

cmsbuild avatar Jul 01 '24 08:07 cmsbuild

A new Pull Request was created by @Mmiglio for master.

It involves the following packages:

  • EventFilter/L1ScoutingRawToDigi (daq)
  • L1TriggerScouting/OnlineProcessing (****)

The following packages do not have a category, yet:

L1TriggerScouting/OnlineProcessing Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks. @Martin-Grunewald, @dinyar, @missirol, @mmusich this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jul 01 '24 08:07 cmsbuild

@cmsbuild please test

smorovic avatar Jul 01 '24 13:07 smorovic

https://github.com/cms-sw/cms-bot/pull/2278 adds new package to cms-bot

smorovic avatar Jul 01 '24 13:07 smorovic

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-329d42/40169/summary.html COMMIT: 936c886c39d0c9ccfb4e76bd082b68d99e8fcb6a CMSSW: CMSSW_14_1_X_2024-07-01-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45350/40169/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345062
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 01 '24 16:07 cmsbuild

+daq

smorovic avatar Jul 01 '24 21:07 smorovic

https://github.com/cms-sw/cms-bot/pull/2276 assigns this new package to l1t category. Can this PR be updated as well? adding @aloeliger as discussed in last week's L1 offline software meeting.

Mmiglio avatar Jul 08 '24 13:07 Mmiglio

Pull request #45350 was updated. @aloeliger, @epalencia can you please check and sign again.

cmsbuild avatar Jul 08 '24 13:07 cmsbuild

+l1

epalencia avatar Jul 11 '24 07:07 epalencia

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 11 '24 07:07 cmsbuild

+1

rappoccio avatar Jul 11 '24 14:07 rappoccio