cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

TICLv5 : Superclustering DNN

Open tcuisset opened this issue 1 year ago • 22 comments

PR description:

This PR brings a new electron superclustering setup for TICLv5. Superclusters can be built either using a DNN or the Mustache algorithm.

Changes :

  • PCA cleaning algorithm (slides)
  • Superclustering DNN (TracksterLinkingBySuperClusteringDNN), with EDAnalyzer for producing training samples (SuperclusteringSampleDumper)
  • Superclustering with Mustache inside TICL (TracksterLinkingbySuperClusteringMustache)
  • Producer to convert superclusters as tracksters to Egamma dataformats and feeding it to electron chain, with energy regression (EGammaSuperclusterProducer)
  • refactored TICLDumper to make it better configurable

Adds three process modifiers to choose between old PF-based Mustache superclustering, new TICL-based Mustache, and DNN-based superclustering.

No changes are expected to workflows that do not enable ticl_v5 modifier (off by default). For ticl_v5 workflows changes in electron reconstruction are expected.

Presentation : TICL meeting

This PR depends on cms-data : cms-data/RecoHGCal-TICL#5

PR validation:

Tested using runTheMatrix workflows :

  • 29691.203 SingleElectronPt15Eta1p7_2p7_2026D110 + ticl_v5
  • 29691.204 SingleElectronPt15Eta1p7_2p7_2026D110 + ticl_v5_mustache
  • 29691.205 SingleElectronPt15Eta1p7_2p7_2026D110 + ticl_v5_mustache_pf
  • 29646.204 ZEE_14TeV_TuneCP5_2026D110 + ticl_v5_mustache
  • 29646.205 ZEE_14TeV_TuneCP5_2026D110 + ticl_v5_mustache_pf

and also 29846.204,29846.205,29891.203,29891.204,29891.205

tcuisset avatar Jun 27 '24 15:06 tcuisset

cms-bot internal usage

cmsbuild avatar Jun 27 '24 15:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45333/40749

  • This PR adds an extra 156KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/README.md modified in PR(s): #33532, #45326
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #44910, #45117, #45326
    • File RecoHGCal/TICL/plugins/TICLCandidateProducer.cc modified in PR(s): #45283
    • File RecoHGCal/TICL/python/customiseForTICLv5_cff.py modified in PR(s): #45283
    • File RecoHGCal/TICL/python/iterativeTICL_cff.py modified in PR(s): #45272, #45283

cmsbuild avatar Jun 27 '24 15:06 cmsbuild

A new Pull Request was created by @tcuisset for master.

It involves the following packages:

  • CommonTools/RecoAlgos (reconstruction)
  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DataFormats/HGCalReco (upgrade, reconstruction)
  • RecoHGCal/Configuration (upgrade, reconstruction)
  • RecoHGCal/TICL (upgrade, reconstruction)
  • SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)
  • Validation/Configuration (simulation, dqm)
  • Validation/HGCalValidation (dqm)

@AdrianoDee, @antoniovagnerini, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @kskovpen, @mandrenguyen, @mdhildreth, @miquork, @nothingface0, @rappoccio, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. @Martin-Grunewald, @abbiendi, @ahinzmann, @apsallid, @bsunanda, @cseez, @fabiocos, @felicepantaleo, @forthommel, @gkasieczka, @hatakeyamak, @jdolen, @jhgoh, @lecriste, @lgray, @makortel, @missirol, @mmusich, @pfs, @rappoccio, @rovere, @sameasy, @sethzenz, @slomeo, @sobhatta, @vandreev11, @youyingli this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jun 27 '24 15:06 cmsbuild

test parameters:

  • workflow_opts= -w upgrade
  • workflow = 29888.203,29688.203

felicepantaleo avatar Jun 27 '24 16:06 felicepantaleo

@cmsbuild please test

felicepantaleo avatar Jun 27 '24 16:06 felicepantaleo

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40131/summary.html COMMIT: e8b0e18a09d0b0291d2ea0a02ffb5a43e4b9f770 CMSSW: CMSSW_14_1_X_2024-06-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

----- Begin Fatal Exception 27-Jun-2024 19:42:59 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_RECO_RECOSIM_PAT_VALIDATION_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/superclustering/regression_v1.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29700.0_CloseByPGun_CE_H_Coarse_Scint+2026D110


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Mixins.py(385): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Mixins.py(520): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 27-Jun-2024 19:42:59 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_RECO_RECOSIM_PAT_VALIDATION_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/superclustering/regression_v1.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29696.0_CloseByPGun_CE_E_Front_120um+2026D110


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Mixins.py(385): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Mixins.py(520): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 27-Jun-2024 19:45:49 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_RECO_RECOSIM_PAT_VALIDATION_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/superclustering/regression_v1.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40131/CMSSW_14_1_X_2024-06-27-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29634.0_TTbar_14TeV+2026D110


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Mixins.py(385): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Mixins.py(520): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-27-1100/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

cmsbuild avatar Jun 27 '24 18:06 cmsbuild

@cmsbuild please test with cms-data/RecoHGCal-TICL#5

rovere avatar Jun 28 '24 08:06 rovere

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40141/summary.html COMMIT: e8b0e18a09d0b0291d2ea0a02ffb5a43e4b9f770 CMSSW: CMSSW_14_1_X_2024-06-27-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40141/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

----- Begin Fatal Exception 28-Jun-2024 12:01:27 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module PFCandidateListMerger/'particleFlowTmp'
   [8] Prefetching for module PFProducer/'particleFlowTmpBarrel'
   [9] Prefetching for module PFBlockProducer/'particleFlowBlock'
   [10] Prefetching for module PFElecTkProducer/'pfTrackElec'
   [11] Prefetching for module GsfTrackProducer/'electronGsfTracks'
   [12] Prefetching for module CkfTrackCandidateMaker/'electronCkfTrackCandidates'
   [13] Prefetching for module ElectronSeedMerger/'electronMergedSeeds'
   [14] Prefetching for module ElectronSeedProducer/'ecalDrivenElectronSeeds'
   [15] Calling method for module EGammaSuperclusterProducer/'particleFlowSuperClusterHGCal'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<ticl::Trackster>
Looking for module label: ticlTracksterLinksSuperclusteringDNN
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 28-Jun-2024 12:01:34 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module PFCandidateListMerger/'particleFlowTmp'
   [8] Prefetching for module PFProducer/'particleFlowTmpBarrel'
   [9] Prefetching for module PFBlockProducer/'particleFlowBlock'
   [10] Prefetching for module PFElecTkProducer/'pfTrackElec'
   [11] Prefetching for module GsfTrackProducer/'electronGsfTracks'
   [12] Prefetching for module CkfTrackCandidateMaker/'electronCkfTrackCandidates'
   [13] Prefetching for module ElectronSeedMerger/'electronMergedSeeds'
   [14] Prefetching for module ElectronSeedProducer/'ecalDrivenElectronSeeds'
   [15] Calling method for module EGammaSuperclusterProducer/'particleFlowSuperClusterHGCal'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<ticl::Trackster>
Looking for module label: ticlTracksterLinksSuperclusteringDNN
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 28-Jun-2024 12:04:37 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module PFCandidateListMerger/'particleFlowTmp'
   [8] Prefetching for module PFProducer/'particleFlowTmpBarrel'
   [9] Prefetching for module PFBlockProducer/'particleFlowBlock'
   [10] Prefetching for module PFElecTkProducer/'pfTrackElec'
   [11] Prefetching for module GsfTrackProducer/'electronGsfTracks'
   [12] Prefetching for module CkfTrackCandidateMaker/'electronCkfTrackCandidates'
   [13] Prefetching for module ElectronSeedMerger/'electronMergedSeeds'
   [14] Prefetching for module ElectronSeedProducer/'ecalDrivenElectronSeeds'
   [15] Calling method for module EGammaSuperclusterProducer/'particleFlowSuperClusterHGCal'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<ticl::Trackster>
Looking for module label: ticlTracksterLinksSuperclusteringDNN
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

cmsbuild avatar Jun 28 '24 12:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45333/40770

  • This PR adds an extra 156KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/README.md modified in PR(s): #33532
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #44910, #45117
    • File RecoHGCal/TICL/plugins/TICLCandidateProducer.cc modified in PR(s): #45283
    • File RecoHGCal/TICL/python/customiseForTICLv5_cff.py modified in PR(s): #45283
    • File RecoHGCal/TICL/python/iterativeTICL_cff.py modified in PR(s): #45272, #45283

cmsbuild avatar Jul 01 '24 09:07 cmsbuild

Pull request #45333 was updated. @AdrianoDee, @antoniovagnerini, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @kskovpen, @mandrenguyen, @mdhildreth, @miquork, @nothingface0, @rappoccio, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild avatar Jul 01 '24 09:07 cmsbuild

test parameters:

  • workflow_opts= -w upgrade
  • workflow = 29888.203,29688.203
  • pull_request = https://github.com/cms-data/RecoHGCal-TICL/pull/5

felicepantaleo avatar Jul 01 '24 11:07 felicepantaleo

@cmsbuild please test

felicepantaleo avatar Jul 01 '24 11:07 felicepantaleo

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40167/summary.html COMMIT: 188e7a57718327659386c78069d3c0e1bdf9b160 CMSSW: CMSSW_14_1_X_2024-07-01-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45333/40167/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @pinchunchou cms-sw/cmssw#44778
  • @smuzaffar cms-sw/cmssw#45214

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40167/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40167/git-merge-result

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1824 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3545730
  • DQMHistoTests: Total failures: 1560
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3544150
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 474.574 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 29688.203,... ): 237.287 KiB HGCAL/HGCalValidator
  • Checked 211 log files, 173 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 01 '24 17:07 cmsbuild

test parameters:

  • workflow_opts= -w upgrade
  • workflow = 29888.203,29688.203,29846.204,29846.205,29891.203,29891.204,29891.205,29691.203,29691.204,29691.205,29646.204,29646.205
  • pull_request = https://github.com/cms-data/RecoHGCal-TICL/pull/5

felicepantaleo avatar Jul 01 '24 18:07 felicepantaleo

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45333/40779

  • This PR adds an extra 156KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/README.md modified in PR(s): #33532
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #33532, #44910, #45117
    • File RecoHGCal/TICL/python/iterativeTICL_cff.py modified in PR(s): #45272

cmsbuild avatar Jul 02 '24 13:07 cmsbuild

Pull request #45333 was updated. @AdrianoDee, @antoniovagnerini, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @kskovpen, @mandrenguyen, @mdhildreth, @miquork, @nothingface0, @rappoccio, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild avatar Jul 02 '24 13:07 cmsbuild

@cmsbuild please test

felicepantaleo avatar Jul 02 '24 14:07 felicepantaleo

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40183/summary.html COMMIT: 378b0659788441beef33315dd1d937e26feb6ea7 CMSSW: CMSSW_14_1_X_2024-07-02-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45333/40183/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

cmsbuild avatar Jul 02 '24 21:07 cmsbuild

enable profiling We think it should be working again after https://github.com/cms-sw/cms-bot/pull/2280 Just using this PR to test the profiling

mandrenguyen avatar Jul 03 '24 01:07 mandrenguyen

please test just re-running to test profiling

mandrenguyen avatar Jul 03 '24 01:07 mandrenguyen

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40190/summary.html COMMIT: 378b0659788441beef33315dd1d937e26feb6ea7 CMSSW: CMSSW_14_1_X_2024-07-02-1100/el8_amd64_gcc12 Additional Tests: PROFILING User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45333/40190/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @kakwok cms-sw/cmssw#44910
  • @rovere cms-sw/cmssw#45178
  • @stahlleiton cms-sw/cmssw#45233
  • @waredjeb cms-sw/cmssw#45272
  • @mseidel42 cms-sw/cmssw#44603
  • @duff-ae cms-sw/cmssw#45348
  • @fwyzard cms-sw/cmssw#45359
  • @rdelliga cms-sw/cmssw#45280
  • @tahuang1991 cms-sw/cmssw#45281
  • @p2l1-gtEmulator cms-sw/cmssw#44995
  • @mseidel42 cms-sw/cmsdist#9111
  • @rovere cms-sw/cmsdist#9231
  • @clelange cms-sw/cmsdist#9280

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40190/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40190/git-merge-result

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 3695 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 17979
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 3327081
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.468 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): -0.078 KiB MTD/Tracks
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

cmsbuild avatar Jul 03 '24 12:07 cmsbuild

enable none it seems we still need to fix some things in cms-bot for Phase-2 profiling

mandrenguyen avatar Jul 03 '24 13:07 mandrenguyen

enable profiling We think it should be working again after https://github.com/cms-sw/cms-bot/pull/2282

jfernan2 avatar Jul 18 '24 08:07 jfernan2

please test just re-running to test profiling since the last test is at least 2 week old now

jfernan2 avatar Jul 18 '24 08:07 jfernan2

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40463/summary.html COMMIT: 378b0659788441beef33315dd1d937e26feb6ea7 CMSSW: CMSSW_14_1_X_2024-07-17-2300/el8_amd64_gcc12 Additional Tests: PROFILING User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45333/40463/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

cmsbuild avatar Jul 18 '24 16:07 cmsbuild

please test workflow 12634.21,29834.21

jfernan2 avatar Jul 22 '24 08:07 jfernan2

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40514/summary.html COMMIT: 378b0659788441beef33315dd1d937e26feb6ea7 CMSSW: CMSSW_14_1_X_2024-07-21-2300/el8_amd64_gcc12 Additional Tests: PROFILING User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45333/40514/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

cmsbuild avatar Jul 22 '24 13:07 cmsbuild

please test workflow 12634.21,29834.21 Last trial trying to get profiling results

jfernan2 avatar Jul 23 '24 16:07 jfernan2

Can this PR be merged, and another PR be used to test profiling? there are two more PRs to be opened on top of this development that should be merged before 14_1_0 is closed.

@tcuisset can you post the results of the timing studies of this pr, so that they can merge it?

felicepantaleo avatar Jul 23 '24 17:07 felicepantaleo

Can this PR be merged, and another PR be used to test profiling? there are two more PRs to be opened on top of this development that should be merged before 14_1_0 is closed.

@tcuisset can you post the results of the timing studies of this pr, so that they can merge it?

Can you please summarize the upcoming PRs?

mandrenguyen avatar Jul 23 '24 18:07 mandrenguyen