cms-sw
Added missing header in StreamerInputModule.h
PR description:
Made header consistent.
PR validation:
Code compiles.
This showed up as a test failure in #45096.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45110/40436
- This PR adds an extra 16KB to repository
A new Pull Request was created by @Dr15Jones for master.
It involves the following packages:
- IOPool/Streamer (core)
@Dr15Jones, @smuzaffar, @makortel can you please review it and eventually sign? Thanks. @wddgit, @makortel this is something you requested to watch as well. @rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
This needs to be added to https://github.com/cms-sw/cmssw/pull/44978 too, right?
Whereas the test release CMSSW_14_0_7_HLTTest discussed in https://github.com/cms-sw/cmssw/pull/45081#issuecomment-2139032118 should be fine, as no further developments are planned on top of that.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c21b3/39634/summary.html
COMMIT: 2e3fcf963b4967f22eb3ecf50ffc410778ba992e
CMSSW: CMSSW_14_1_X_2024-05-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45110/39634/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @mmusich cms-sw/cmssw#45063
- @VinInn cms-sw/cmssw#45091
- @iarspider cms-sw/cmssw#45093
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c21b3/39634/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c21b3/39634/git-merge-result
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 12 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338836
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This needs to be added to https://github.com/cms-sw/cmssw/pull/44978 too, right?
I don't think we apply the header consistency checks in older releases. The above PR is only needed for that check, all code already compiles fine.
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
