cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

remove unused mkFitHitConverter_cfi.py

Open slava77 opened this issue 1 year ago • 5 comments

related to one of the topics in #45106

slava77 avatar May 30 '24 16:05 slava77

cms-bot internal usage

cmsbuild avatar May 30 '24 16:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45109/40435

  • This PR adds an extra 20KB to repository

cmsbuild avatar May 30 '24 16:05 cmsbuild

@cmsbuild please test

slava77 avatar May 30 '24 16:05 slava77

A new Pull Request was created by @slava77 for master.

It involves the following packages:

  • RecoTracker/MkFit (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks. @mmusich, @JanFSchulte, @rovere, @felicepantaleo, @mtosi, @missirol, @VinInn, @gpetruc, @VourMa, @GiacomoSguazzoni, @makortel, @dgulhan this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 30 '24 16:05 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d447f/39633/summary.html COMMIT: dda20b28a3787791b9eb4762b4b12a696ac63f83 CMSSW: CMSSW_14_1_X_2024-05-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45109/39633/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3445370
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3445347
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 30 '24 19:05 cmsbuild

+1

jfernan2 avatar May 31 '24 09:05 jfernan2

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 31 '24 09:05 cmsbuild

+1

rappoccio avatar May 31 '24 16:05 rappoccio