cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Added value method to additional python Parameter types

Open Dr15Jones opened this issue 1 year ago • 7 comments

PR description:

  • Added to EventID, LuminosityBlockID, EventRange and LuminosityBlockRange.
  • Minor code improvements.

PR validation:

Code compiles and unit tests pass.

Dr15Jones avatar May 30 '24 15:05 Dr15Jones

cms-bot internal usage

cmsbuild avatar May 30 '24 15:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45108/40434

  • This PR adds an extra 32KB to repository

cmsbuild avatar May 30 '24 15:05 cmsbuild

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/ParameterSet (core)

@smuzaffar, @makortel, @Dr15Jones, @cmsbuild can you please review it and eventually sign? Thanks. @wddgit, @missirol, @makortel this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 30 '24 15:05 cmsbuild

please test

Dr15Jones avatar May 30 '24 15:05 Dr15Jones

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f791b5/39631/summary.html COMMIT: 20760916bb7946e811fa4522a17c0c77ccf9be67 CMSSW: CMSSW_14_1_X_2024-05-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45108/39631/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @mmusich cms-sw/cmssw#45063
  • @VinInn cms-sw/cmssw#45091
  • @iarspider cms-sw/cmssw#45093

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f791b5/39631/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f791b5/39631/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338839
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 30 '24 18:05 cmsbuild

+core

makortel avatar May 30 '24 20:05 makortel

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 30 '24 20:05 cmsbuild

+1

rappoccio avatar May 31 '24 16:05 rappoccio