cms-sw
[14_0_X] EMTF emulator support for 2024 primitive converison LUTs
PR description:
This PR adds options to use the new primitive conversion LUTs in the EMTF emulator. The LUTs were deployed at P5 on May 28th, but they are not used in the emulator yet.
This PR needs the LUTs in https://github.com/cms-data/L1Trigger-L1TMuon/pull/28 to work.
We see improvement in EMTF performance at P5 with these new LUTs, so changes to muon efficiencies etc are expected when testing the re-emulation workflows from recent runs.
PR validation:
Validated by comparing unpacked and re-emulated collections from recent runs. Emulator picks the correct LUTs based on firmware version. Results are as expected.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is the backport of https://github.com/cms-sw/cmssw/pull/45105. It's not urgent, but it is needed to reduce DQM mismatches between EMTF fw and emulator.
N/A
A new Pull Request was created by @eyigitba for CMSSW_14_0_X.
It involves the following packages:
- HLTrigger/HLTfilters (hlt)
- L1Trigger/L1TMuonEndCap (l1)
- RecoEgamma/PhotonIdentification (reconstruction)
@epalencia, @mmusich, @cmsbuild, @mandrenguyen, @aloeliger, @jfernan2, @Martin-Grunewald can you please review it and eventually sign? Thanks. @sobhatta, @lgray, @dinyar, @ram1123, @missirol, @Prasant1993, @a-kapoor, @jainshilpi, @Sam-Harper, @thomreis, @silviodonato, @afiqaize, @varuns23, @JanFSchulte, @valsdav, @Martin-Grunewald, @sameasy this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
- Backported from #45105
@eyigitba can you please rebase your branch to get rid of commits f40fd9ae7bc90dcdd84bb804e19195c6144d27e8 and a58160f973efa6817203a97d168ac3dd78031254? that will eliminate the need of (unneeded) HLT and RECO signatures.
Could you please re-base so that the other two commits included disappear? Thanks!
Hi @mmusich @Martin-Grunewald , I only just saw your comments. I'll fix it later today. Thanks for catching it.
test parameters: pull_request = https://github.com/cms-data/L1Trigger-L1TMuon/pull/28
Pull request #45107 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a8ba8/39685/summary.html
COMMIT: 1d0e9554625f7ff3d657e1424de644c232694494
CMSSW: CMSSW_14_0_X_2024-06-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45107/39685/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 4 lines to the logs
- Reco comparison results: 62 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338712
- DQMHistoTests: Total failures: 1202
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3337490
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
@aloeliger @epalencia , can we approve and eventually merge this PR to be ready by 14_0_9 if possible? The only impact will be on online DQM, so it's not super urgent but it's good for stable operations.
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
@eyigitba @cms-sw/l1-l2 Could you please backport the tag update in https://github.com/cms-sw/cmsdist/pull/9226 ?
@eyigitba @cms-sw/l1-l2 Could you please backport the tag update in cms-sw/cmsdist#9226 ?
@antoniovilela Done in https://github.com/cms-sw/cmsdist/pull/9235
@antoniovilela can we merge this if there are no other remaining issues? Thanks
