cms-sw
EMTF emulator support for 2024 primitive converison LUTs
PR description:
This PR adds options to use the new primitive conversion LUTs in the EMTF emulator. The LUTs were deployed at P5 on May 28th, but they are not used in the emulator yet.
This PR needs the LUTs in https://github.com/cms-data/L1Trigger-L1TMuon/pull/28 to work.
We see improvement in EMTF performance at P5 with these new LUTs, so changes to muon efficiencies etc are expected when testing the re-emulation workflows from recent runs.
This PR will be backported to 14_0_X.
PR validation:
Validated by comparing unpacked and re-emulated collections from recent runs. Emulator picks the correct LUTs based on firmware version. Results are as expected.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45105/40433
- This PR adds an extra 24KB to repository
A new Pull Request was created by @eyigitba for master.
It involves the following packages:
- L1Trigger/L1TMuonEndCap (l1)
@epalencia, @aloeliger, @cmsbuild can you please review it and eventually sign? Thanks. @missirol, @JanFSchulte, @thomreis, @Martin-Grunewald, @dinyar this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acae34/39632/summary.html
COMMIT: f6ec1357a2333fff5c2013e82414a8d7d91f2bee
CMSSW: CMSSW_14_1_X_2024-05-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45105/39632/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @mmusich cms-sw/cmssw#45063
- @VinInn cms-sw/cmssw#45091
- @iarspider cms-sw/cmssw#45093
- @cms-sw cms-sw/cmsdist#9216
- @aloeliger cms-sw/cmsdist#9214
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acae34/39632/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acae34/39632/git-merge-result
Comparison Summary
Summary:
- You potentially added 13 lines to the logs
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338839
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/L1Trigger-L1TMuon#28
https://github.com/cms-data/L1Trigger-L1TMuon/pull/28 now merged. cmsdist PR: https://github.com/cms-sw/cmsdist/pull/9226
