cms-sw
[RFC] [CPP20] Remove volatile from CondCore/Utilities
PR description:
Addressing #45072
This PR removes the only occurrence of a volatile variable in CondCore/Utilities.
The cpp script containing such variable is not run in production and not even run as unitTest.
The [RFC] in the title is due to the fact that I'm not 100% sure this is the correct way of handling this, at least I could not understand if there are preferred ways to address this deprecation from the link in the original issue, but I don't have much experience with this. 😄
@iarspider @VinInn any feedback is more than welcome.
PR validation:
Code compiles. Additionally, I have run the following command:
conddb_test_gt_perf -g 80X_dataRun2_HLT_for800Validatio_test -n 1 -c oracle://cms_orcoff_prep/CMS_CONDITIONS --n_fetch 1 --n_deser 1 2>&1 | tee run.log
with and without this PR and the test passes with the same result.
Backport:
Not a backport, no backport needed
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45104/40432
- This PR adds an extra 20KB to repository
A new Pull Request was created by @francescobrivio for master.
It involves the following packages:
- CondCore/Utilities (db)
@saumyaphor4252, @perrotta, @consuegs, @francescobrivio can you please review it and eventually sign? Thanks. @PonIlya, @yuanchao, @rsreds, @JanChyczynski, @mmusich this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39630/summary.html
COMMIT: 87272090e2bb7602f17719dc4f0922e4e62c6859
CMSSW: CMSSW_14_1_CPP20_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45104/39630/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @mbluj cms-sw/cmssw#44984
- @abdoulline cms-sw/cmssw#45033
- @mbluj cms-sw/cmssw#45030
- @bsunanda cms-sw/cmssw#45036
- @cms-sw cms-sw/cmssw#45034
- @stahlleiton cms-sw/cmssw#45024
- @iarspider cms-sw/cmssw#45038
- @bsunanda cms-sw/cmssw#45046
- @bsunanda cms-sw/cmssw#45044
- @bsunanda cms-sw/cmssw#45045
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39630/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39630/git-merge-result
Comparison Summary
Summary:
- You potentially added 2561 lines to the logs
- Reco comparison results: 122 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 956
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3337886
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45104/40441
- This PR adds an extra 20KB to repository
Pull request #45104 was updated. @cmsbuild, @francescobrivio, @consuegs, @saumyaphor4252, @perrotta can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39639/summary.html
COMMIT: 8c32195e23b94812eac2137b3d6914ef726ff51b
CMSSW: CMSSW_14_1_CPP20_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45104/39639/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @mbluj cms-sw/cmssw#44984
- @abdoulline cms-sw/cmssw#45033
- @mbluj cms-sw/cmssw#45030
- @bsunanda cms-sw/cmssw#45036
- @cms-sw cms-sw/cmssw#45034
- @stahlleiton cms-sw/cmssw#45024
- @iarspider cms-sw/cmssw#45038
- @bsunanda cms-sw/cmssw#45046
- @bsunanda cms-sw/cmssw#45044
- @bsunanda cms-sw/cmssw#45045
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39639/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39639/git-merge-result
Comparison Summary
Summary:
- You potentially added 2566 lines to the logs
- Reco comparison results: 124 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 962
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3337880
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39660/summary.html
COMMIT: 8c32195e23b94812eac2137b3d6914ef726ff51b
CMSSW: CMSSW_14_1_X_2024-06-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45104/39660/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 1 lines from the logs
- Reco comparison results: 12 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 9
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338833
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
