cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Noisy PileupJetIdProducer in Prompt reconstruction

Open makortel opened this issue 1 year ago • 12 comments

While investigating a PromptReco reproducer in https://github.com/cms-sw/cmssw/issues/45089#issue-2322763515 I noticed many printouts along

%MSG-e FactorizedJetCorrectorCalculator:   PileupJetIdProducer:pileupJetIdCalculatorPUPPIDQM 29-May-2024 23:36:50 CEST  Run: 381067 Event: 682965806
jet phi is not set
%MSG

from pileupJetIdCalculatorPUPPIDQM and pileupJetIdCalculatorCHSDQM. In that example job, in 26466 events there were total of 4733863 printouts, corresponding to 767 MB of log.

Could these be silenced in some way?

makortel avatar May 30 '24 13:05 makortel

assign reconstruction, dqm

makortel avatar May 30 '24 13:05 makortel

New categories assigned: reconstruction,dqm

@jfernan2,@mandrenguyen,@rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar May 30 '24 13:05 cmsbuild

cms-bot internal usage

cmsbuild avatar May 30 '24 13:05 cmsbuild

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @rappoccio, @sextonkennedy, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

cmsbuild avatar May 30 '24 13:05 cmsbuild

Could somebody look into this? The amount of logs is quite substantial.

makortel avatar Jun 04 '24 18:06 makortel

type jetmet

jfernan2 avatar Jun 05 '24 09:06 jfernan2

@iatakisi as current DQM Offline expert, could you please have a look?

jfernan2 avatar Jun 05 '24 09:06 jfernan2

@makortel @jfernan2 has this been resolved? I can take a look at this from the jetmet side.

nurfikri89 avatar Jun 19 '24 15:06 nurfikri89

No, it has not, please have a llok and make a proposal for solution. Thanks

jfernan2 avatar Jun 19 '24 15:06 jfernan2

The printouts appear because one of the levels in the latest JECs is now dependent on jet phi. The variable is not explicitly set here:

https://github.com/cms-sw/cmssw/blob/77c6c383f4c1af489c3778cc052abe2e737c0808/RecoJets/JetProducers/plugins/PileupJetIdProducer.cc#L158-L165

Simply adding jecCor_->setJetPhi(jet.phi()); suppress the message. I have tested that the prinouts no longer appear using RunPromptReco.py. The PRs for the master and 14_0_X branches will be submitted shortly.

nurfikri89 avatar Jun 19 '24 20:06 nurfikri89

Thanks @nurfikri89 !

jfernan2 avatar Jun 20 '24 07:06 jfernan2

+1 Fixed by https://github.com/cms-sw/cmssw/pull/45270

jfernan2 avatar Jul 02 '24 09:07 jfernan2