cms-sw
(DAQ) fix lock contention in source
PR description:
Fixes lock contention in source. Lock is used for setting up waiting on the condition variable, but it should be released after.
However, the lock is automatically reacquired at the end of wait as described:
https://en.cppreference.com/w/cpp/thread/condition_variable/wait
In production HLT this is seen to take significant time in the source (8-20% depending on data flow conditions and configuration) and could be the cause preventing using top ~10% of the CPU capacity in HLT.
Also, more logging (destination info) is added for the case of file broker connection issues.
PR validation:
Tested in daq3val system with both FedRawDataInputSource and DAQSource.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45097/40431
- This PR adds an extra 52KB to repository
A new Pull Request was created by @smorovic for master.
It involves the following packages:
- EventFilter/Utilities (daq)
@emeschi, @smorovic, @cmsbuild can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d84d30/39625/summary.html
COMMIT: 46c71e0c85732d10c6df89783aaa6615c8a7fe9f
CMSSW: CMSSW_14_1_X_2024-05-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45097/39625/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338839
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
