cms-sw
Phase2-hgx357 Add a new version of HGCalCellOffest to provide a more correct results for the cell areas
PR description:
Add a new version of HGCalCellOffest to provide a more correct results for the cell areas
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45095/40426
- This PR adds an extra 52KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
- code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45095/40426/code-format.patch
e.g.
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45095/40426/code-format.patch | patch -p1You can also runscram build code-formatto apply code format directly
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45095/40427
- This PR adds an extra 56KB to repository
A new Pull Request was created by @bsunanda for master.
It involves the following packages:
- Geometry/HGCalCommonData (upgrade, geometry)
- SimG4CMS/Calo (simulation)
@Dr15Jones, @civanch, @bsunanda, @subirsarkar, @srimanob, @mdhildreth, @makortel, @cmsbuild can you please review it and eventually sign? Thanks. @wang0jin, @fabiocos, @rovere, @thomreis, @ReyerBand, @felicepantaleo, @slomeo this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92b4fe/39618/summary.html
COMMIT: d4ca72eb33d6b26dcbb37fa7ea874fd7bdb1d60e
CMSSW: CMSSW_14_1_X_2024-05-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45095/39618/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 5 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338836
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
A note on warning, not about this PR
Analyzing src/SimG4CMS/Calo/src/HcalTestNumberingScheme.cc src/SimG4CMS/Calo/src/CaloSD.cc:423:102: warning: Called C++ object pointer is null [core.CallAndMessage] 423 | edm::LogVerbatim("CaloSim") << "CaloSD: EndofEvent entered for container " << k << " with " << theHC[0]->entries() | ^~~~~~~~~~~~~~~~~~~ 1 warning generated.
FYI @bsunanda @civanch
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45095/40459
- This PR adds an extra 28KB to repository
Pull request #45095 was updated. @mdhildreth, @civanch can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92b4fe/39671/summary.html
COMMIT: 56c003bcbee3d6989f3ff68ff5eac20e35a779a8
CMSSW: CMSSW_14_1_X_2024-06-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45095/39671/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 4 lines to the logs
- Reco comparison results: 5 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 4
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338838
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
