cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Removed duplicate cfi file in L1Trigger/L1CaloTrigger

Open Dr15Jones opened this issue 1 year ago • 7 comments

PR description:

The same named cfi file was generated and placed in cfipython and the package's python directory.

PR validation:

Code compiles.

Dr15Jones avatar May 29 '24 20:05 Dr15Jones

cms-bot internal usage

cmsbuild avatar May 29 '24 20:05 cmsbuild

If one tried to use this _cfi.py file, it would attempt to load itself.

Dr15Jones avatar May 29 '24 20:05 Dr15Jones

please test

Dr15Jones avatar May 29 '24 20:05 Dr15Jones

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45094/40424

  • This PR adds an extra 16KB to repository

cmsbuild avatar May 29 '24 20:05 cmsbuild

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • L1Trigger/L1CaloTrigger (upgrade, l1)

@subirsarkar, @epalencia, @aloeliger, @srimanob can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 29 '24 20:05 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-268da2/39616/summary.html COMMIT: b697b6db952675f19ed36e500125c72147445068 CMSSW: CMSSW_14_1_X_2024-05-29-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45094/39616/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338830
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 29 '24 23:05 cmsbuild

+l1

aloeliger avatar May 30 '24 09:05 aloeliger

+Upgrade

srimanob avatar Jun 03 '24 09:06 srimanob

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jun 03 '24 09:06 cmsbuild

+1

rappoccio avatar Jun 03 '24 14:06 rappoccio