Fix maybe-uninitialized warnings in Zmumumerge.cc

[iarspider]

PR description:

Fixes the following warnings in ASAN IBs:

src/Alignment/OfflineValidation/bin/Zmumumerge.cc: In function 'void Draw_TH1D_forMultiRootFiles(const std::vector<TString>&, const std::vector<TString>&, const std::vector<int>&, const std::vector<int>&, const TString&, const TString&, const TString&, const TString&, const TString&)':
  src/Alignment/OfflineValidation/bin/Zmumumerge.cc:331:29: warning: 'ymax' may be used uninitialized [-Wmaybe-uninitialized]
   331 |       double yrange = (ymax - ymin) * 2;
      |                       ~~~~~~^~~~~~~
src/Alignment/OfflineValidation/bin/Zmumumerge.cc:302:10: note: 'ymax' was declared here
  302 |   double ymax;
      |          ^~~~
  src/Alignment/OfflineValidation/bin/Zmumumerge.cc:331:29: warning: 'ymin' may be used uninitialized [-Wmaybe-uninitialized]
   331 |       double yrange = (ymax - ymin) * 2;
      |                       ~~~~~~^~~~~~~
src/Alignment/OfflineValidation/bin/Zmumumerge.cc:301:10: note: 'ymin' was declared here
  301 |   double ymin;
      |          ^~~~

PR validation:

Bot tests

[iarspider]

please test for CMSSW_14_1_ASAN_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45088/40408

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@perrotta, @saumyaphor4252, @consuegs can you please review it and eventually sign? Thanks. @mmusich, @rsreds, @adewit, @tocheng, @yuanchao, @tlampen this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f45af/39598/summary.html COMMIT: 9ef32ea1bf1d9cadc2fb97453b086e63e049d1c1 CMSSW: CMSSW_14_1_X_2024-05-28-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45088/39598/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338836
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

• The initialization values chosen make sense

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f45af/39599/summary.html COMMIT: 9ef32ea1bf1d9cadc2fb97453b086e63e049d1c1 CMSSW: CMSSW_14_1_ASAN_X_2024-05-27-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45088/39599/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test SubmitPVsplit had ERRORS

[rappoccio]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f45af/39612/summary.html COMMIT: 9ef32ea1bf1d9cadc2fb97453b086e63e049d1c1 CMSSW: CMSSW_14_1_X_2024-05-29-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45088/39612/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338836
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[antoniovilela]

please test for CMSSW_14_1_ASAN_X

[iarspider]

please test for CMSSW_14_1_ASAN_X

[cmsbuild]

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f45af/39833/summary.html COMMIT: 9ef32ea1bf1d9cadc2fb97453b086e63e049d1c1 CMSSW: CMSSW_14_1_ASAN_X_2024-06-10-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45088/39833/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test SubmitPVsplit had ERRORS

[rappoccio]

+1

[rappoccio]

merge