cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Adds muon shower triggers for MC data

Open nabrandman opened this issue 1 year ago • 6 comments

PR description:

Implements HMT triggers in test vector code with MC data files for uGT emulator in master.

No changes are expected to the output.

This PR does not depend on any other PRs or externals.

PR validation:

Performed runTheMatrix with -l 11634.0, passed 5 out of 5 tests. Test vector code was also validated with firmware and was shown to be equivalent.

Changes were checked against "scram build code-format" to ensure they followed CMS Naming, Coding and Style Rules.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport.

nabrandman avatar May 29 '24 00:05 nabrandman

cms-bot internal usage

cmsbuild avatar May 29 '24 00:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45086/40405

  • This PR adds an extra 28KB to repository

cmsbuild avatar May 29 '24 00:05 cmsbuild

A new Pull Request was created by @nabrandman for master.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 29 '24 00:05 cmsbuild

These updates are a follow up of the changes included in https://github.com/cms-sw/cmssw/pull/43921. This PR has been validated via test vectors with the firmware group.

SETUP for producing test vectors: cmsrel CMSSW_14_0_6 cd CMSSW_14_0_6/src cmsenv git cms-init git cms-addpkg L1Trigger/L1TGlobal mkdir -p L1Trigger/L1TGlobal/data/Luminosity/startup cd L1Trigger/L1TGlobal/data/Luminosity/startup wget https://raw.githubusercontent.com/cms-l1-dpg/L1MenuRun3/master/development/L1Menu_Collisions2024_v1_2_0/L1Menu_Collisions2024_v1_2_0.xml cd -

SCRIPT for producing test vectors: cp test/runGlobalFakeInputProducer.py cmsRun runGlobalFakeInputProducer.py

Set of files:

/store/relval/CMSSW_14_0_1/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/140X_mcRun3_2024_realistic_v4_PU_AlpakaVal_AlpakaDeviceVSHost-v14/50000/34ae12a4-2d90-4d5d-b24\
3-e949af0952ae.root                                                                                                                                                 
/store/relval/CMSSW_14_0_1/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/140X_mcRun3_2024_realistic_v4_PU_AlpakaVal_AlpakaDeviceVSHost-v14/50000/5c08de0e-0571-4792-aa3\
7-1b7d1915dbda.root                                                                                                                                                 
/store/relval/CMSSW_14_0_1/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/140X_mcRun3_2024_realistic_v4_PU_AlpakaVal_AlpakaDeviceVSHost-v14/50000/1aed742b-2f48-4cc3-875\
8-24153c38c79b.root                                                                                                                                                 
/store/relval/CMSSW_14_0_1/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/140X_mcRun3_2024_realistic_v4_PU_AlpakaVal_AlpakaDeviceVSHost-v14/50000/096ba83b-620d-449d-a40\
8-ebb209b54d76.root

Countings:

L1 Bit Simulation Firmware
L1_TwoMuShower_Loose 1811 1811
L1_SingleMuShower_Nominal 1727 1727
L1_SingleMuShower_Tight 1768 1768

elfontan avatar May 29 '24 14:05 elfontan

Please test

epalencia avatar May 29 '24 15:05 epalencia

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52170c/39611/summary.html COMMIT: 3d4f24e53a806d2574e64eaf2737fef48a427aff CMSSW: CMSSW_14_1_X_2024-05-29-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45086/39611/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338833
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 29 '24 18:05 cmsbuild

+l1

aloeliger avatar Jun 12 '24 14:06 aloeliger

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jun 12 '24 14:06 cmsbuild

+1

rappoccio avatar Jun 13 '24 15:06 rappoccio