cms-sw
avoid crashing when encounter unphysical GEM pad numbers; add logging
PR description:
Add checks to avoid crashing GEMClusterProcessor when it accesses lookup table values corresponding to unphysical GEM pad numbers (greater than 192). If any unphysical pad numbers are discovered for a cluster being processed, cluster is reset to empty value so that it is skipped by the function doing coordinate conversion. The issue is most likely due to unstable GEM links and is currently being investigated.
Slides with additional information are attached. unphysical_gem_pads.pdf
PR validation:
Emulator code was run locally to make sure no crashes occur.
A new Pull Request was created by @abolshov for CMSSW_13_0_X.
It involves the following packages:
- L1Trigger/CSCTriggerPrimitives (l1)
@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks. @ptcox, @missirol, @valuev, @JanFSchulte, @eyigitba, @Martin-Grunewald, @giovanni-mocellin this is something you requested to watch as well. @rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
Is it better to make this PR to the master branch and backport it to CMSSW_13_0_x?
@abolshov @tahuang1991 Standard procedure is to make all PRs to the master branch, and then backport them. Please make this PR first to the master version of CMSSW.
Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all