cms-sw
[MTD] Update MTD hit pattern + add outermost hits position in the TrackExtenderWithMTD
PR description:
This PR includes
- an update of the hit pattern for MTD
- the addition of a ValueMap, filled within the TrackExtenderWithMTD, to store the track outermost hit position (R for tracks with hits in BTL, Z for tracks with hits in ETL).
PR validation:
The code was tested on wf 24906.0 and 24807.0.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45074/40389
-
This PR adds an extra 68KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMTD/TrackExtender/plugins/TrackExtenderWithMTD.cc modified in PR(s): #44785
- File Validation/MtdValidation/plugins/MtdTracksValidation.cc modified in PR(s): #43928
A new Pull Request was created by @martinamalberti for master.
It involves the following packages:
- DataFormats/ForwardDetId (simulation, upgrade)
- DataFormats/TrackReco (reconstruction)
- RecoMTD/TrackExtender (upgrade, reconstruction)
- Validation/MtdValidation (dqm)
@rvenditti, @mdhildreth, @srimanob, @nothingface0, @syuvivida, @jfernan2, @tjavaid, @cmsbuild, @subirsarkar, @antoniovagnerini, @mandrenguyen, @civanch can you please review it and eventually sign? Thanks. @JanFSchulte, @mtosi, @bsunanda, @mmusich, @gpetruc, @rovere, @VourMa, @VinInn, @apsallid, @fabiocos, @youyingli, @missirol this is something you requested to watch as well. @antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-261153/39579/summary.html
COMMIT: 37f71a94bb616b9c1bd61e2d9a782fd3cbb82d46
CMSSW: CMSSW_14_1_X_2024-05-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45074/39579/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3445370
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3445344
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 3.7139999999999995 KiB( 48 files compared)
- DQMHistoSizes: changed ( 23234.0,... ): 0.619 KiB MTD/Tracks
- Checked 206 log files, 170 edm output root files, 49 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
