cms-sw
[CPP20][DQM] Fix deprecated enum arithmetics in TkAlCaRecoMonitor and SiPixelPhase1RawDataErrorComparator
PR description:
Fix the following compilation warnings:
src/DQMOffline/Alignment/src/TkAlCaRecoMonitor.cc: In member function 'virtual void TkAlCaRecoMonitor::bookHistograms(dqm::legacy::DQMStore::IBooker&, const edm::Run&, const edm::EventSetup&)':
src/DQMOffline/Alignment/src/TkAlCaRecoMonitor.cc:76:114: warning: arithmetic between enumeration type 'reco::TrackBase::TrackQuality' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
76 | histname + AlgoName, histname + AlgoName, reco::TrackBase::qualitySize, -0.5, reco::TrackBase::qualitySize - 0.5);
|
src/DQM/SiPixelHeterogeneous/plugins/SiPixelPhase1RawDataErrorComparator.cc: In member function 'virtual void SiPixelPhase1RawDataErrorComparator::bookHistograms(dqm::legacy::DQMStore::IBooker&, const edm::Run&, const edm::EventSetup&)':
src/DQM/SiPixelHeterogeneous/plugins/SiPixelPhase1RawDataErrorComparator.cc:267:54: warning: arithmetic between enumeration type 'FEDNumbering::<unnamed enum>' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
267 | FEDNumbering::MINSiPixeluTCAFEDID - 0.5,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
src/DQM/SiPixelHeterogeneous/plugins/SiPixelPhase1RawDataErrorComparator.cc:268:54: warning: arithmetic between enumeration type 'FEDNumbering::<unnamed enum>' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
268 | FEDNumbering::MAXSiPixeluTCAFEDID - 0.5);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
PR validation:
Bot tests
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45071/40387
- This PR adds an extra 24KB to repository
A new Pull Request was created by @iarspider for master.
It involves the following packages:
- DQM/SiPixelHeterogeneous (dqm)
- DQMOffline/Alignment (dqm)
@syuvivida, @tjavaid, @nothingface0, @rvenditti, @cmsbuild, @antoniovagnerini can you please review it and eventually sign? Thanks. @idebruyn, @rociovilar, @mmusich, @threus, @jandrea, @fioriNTU this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73bef3/39573/summary.html
COMMIT: 35a185ec7255238daa8986beb8648bcfe6cd10b9
CMSSW: CMSSW_14_1_CPP20_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45071/39573/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 2619 lines to the logs
- Reco comparison results: 120 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 899
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3337943
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73bef3/39578/summary.html
COMMIT: 35a185ec7255238daa8986beb8648bcfe6cd10b9
CMSSW: CMSSW_14_1_X_2024-05-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45071/39578/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 1 lines from the logs
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338836
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
