cms-sw
Include per ROC histograms for Pixel Cluster Counting luminosity - CMSSW_14_0_X
Including extra loops to AlcaPCCEventProducer to iterate over clusters and sort them by corresponding ROC modules. Later the information is used to produce luminosity histograms (per bx) with per ROC granularity at HLT. This information could be used to identify the outliers and improve the stability and linearity of Pixel Cluster Counting luminosity (talk by B. Kronheim and C. Palmer https://indico.cern.ch/event/1358674/contributions/5725781/attachments/2775100/4836057/PCC_Active_Masking_Dec_19_2023.pdf)
PR validation:
Merged in master since CMSSW_14_1_0_pre4
backport of PR #44996
PLEASE NOTICE
Once this PR gets merged in CMSSW_14_0_X and deployed in Tier0 for data-taking, we will need at least a processing version change! (See also the notes taken during the Joint Ops meeting on May 27)
A new Pull Request was created by @perrotta for CMSSW_14_0_X.
It involves the following packages:
- Calibration/LumiAlCaRecoProducers (alca)
- DataFormats/Luminosity (reconstruction)
@mandrenguyen, @cmsbuild, @perrotta, @jfernan2, @saumyaphor4252, @consuegs can you please review it and eventually sign? Thanks. @mmusich, @rsreds, @tocheng, @rovere, @missirol, @yuanchao this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
- Backported from #44996
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b3b84/39540/summary.html
COMMIT: 64e31f9bf3cf88971292621fe7e1ae967d3a7e24
CMSSW: CMSSW_14_0_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45054/39540/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 89 lines from the logs
- Reco comparison results: 145 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3333953
- DQMHistoTests: Total failures: 2580
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3331353
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+alca
- Verbatim backport of #44996
- It modifies the DataFormat for PixelClusterCounts and PixelClusterCountsInEvent
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
for the record, it looks like this PR lead to https://github.com/cms-sw/cmssw/issues/45306
for the record, it looks like this PR lead to #45306
@duff-ae (as the original author of the code) please have a look
@perrotta Dear Andrea, I've prepared a fix for the issue https://github.com/cms-sw/cmssw/pull/45348
