Protection for invalid TSOS in MuonTrajectoryUpdator

[24LopezR]

PR description:

This PR addresses https://github.com/cms-sw/cmssw/issues/45035 Attempts to fix a crash observed when KFUpdator returns an invalid trajectory state on surface. Whenever this happens, muon trajectory updator skips that recHit.

FYI @francescobrivio @mmusich @mandrenguyen @jfernan2 @rbhattacharya04

PR validation:

Tested successfully in conditions detailed in issue https://github.com/cms-sw/cmssw/issues/45035.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR needs to be backported to 14_0_X.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45053/40362

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45053/40362/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45053/40362/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[mmusich]

@24LopezR can you apply the code-formatting at https://github.com/cms-sw/cmssw/pull/45053#issuecomment-2133266925 ?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45053/40363

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @24LopezR for master.

It involves the following packages:

• RecoMuon/TrackingTools (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks. @bellan, @abbiendi, @jhgoh, @HuguesBrun, @andrea21z, @JanFSchulte, @missirol, @CeliaFernandez, @rociovilar, @cericeci, @trocino, @Fedespring this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-179a50/39542/summary.html COMMIT: cc14fb2e9bcfe9d97bb7f1e5ba8761b9478974c5 CMSSW: CMSSW_14_1_X_2024-05-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45053/39542/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338836
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

Thanks @24LopezR

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

@24LopezR can you prepare a 14_0_X backport please?

[mmusich]

type muon

[rappoccio]

+1