cms-sw
Fix compilation warning in DDHGCalPassive.cc
PR description:
Fix compilation warning in DDHGCalPassive.cc:
>> Compiling src/Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalTBModule.cc
.../bin/clang++ <...> src/Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalTBModule.cc -o tmp/el8_amd64_gcc12/src/Geometry/HGCalCommonData/plugins/DD4hep_GeometryHGCalCommonDataPlugins/dd4hep/DDHGCalTBModule.cc.o
src/Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalPassive.cc:104:34: warning: variable 'parentName' is uninitialized when used within its own initialization [-Wuninitialized]
104 | std::string parentName = parentName + tagLayer[j] + tagSector[k];
| ~~~~~~~~~~ ^~~~~~~~~~
@bsunanda could you please confirm that the generated solids' should be {parentName}{tagLayer[j]}{tagSector[k]} and not {parentName}{tagLayer[0]}{tagSector[0]}{tagLayer[1]}{tagSector[0]}{tagSector[1]}...{tagLayer[j]}{tagSector[k]} (if that has any importance)?
PR validation:
Bot tests
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45052/40359
- This PR adds an extra 20KB to repository
A new Pull Request was created by @iarspider for master.
It involves the following packages:
- Geometry/HGCalCommonData (upgrade, geometry)
@civanch, @makortel, @mdhildreth, @srimanob, @subirsarkar, @Dr15Jones, @bsunanda can you please review it and eventually sign? Thanks. @fabiocos, @bsunanda this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43e48d/39536/summary.html
COMMIT: 3128f995a25bdfe28f42c8d12c6278f575a7867a
CMSSW: CMSSW_14_1_CLANG_X_2024-05-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45052/39536/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @mmusich cms-sw/cmssw#45042
- @alaperto cms-sw/cmssw#45026
- @mandrenguyen cms-sw/cmssw#45049
- @missirol cms-sw/cmssw#45047
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43e48d/39536/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43e48d/39536/git-merge-result
Comparison Summary
Summary:
- You potentially added 14199 lines to the logs
- Reco comparison results: 30347 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 37993
- DQMHistoTests: Total nulls: 154
- DQMHistoTests: Total successes: 3300695
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.026999999999999993 KiB( 47 files compared)
- DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
- DQMHistoSizes: changed ( 140.063 ): 0.012 KiB JetMET/SUSYDQM
- DQMHistoSizes: changed ( 141.042 ): 0.051 KiB JetMET/SUSYDQM
- DQMHistoSizes: changed ( 141.044 ): -0.020 KiB JetMET/SUSYDQM
- DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: found differences in 4 / 46 workflows
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43e48d/39550/summary.html
COMMIT: 3128f995a25bdfe28f42c8d12c6278f575a7867a
CMSSW: CMSSW_14_1_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45052/39550/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 9 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338862
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338836
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
