cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Add Unpacker for L1T Calo Layer 1 to unpack CICADA

Open aloeliger opened this issue 1 year ago • 6 comments

PR description:

This PR adds an unpacker to the L1T Calo Layer 1 Unpacking Setup to explicitly unpack CICADA (found in FED 1356, AMC slot 7). This PR relies on data-types introduced in it's companion PR https://github.com/cms-sw/cmssw/pull/44222. https://github.com/cms-sw/cmssw/pull/44222 Unpacks the uGT received CICADA scores, while this PR unpacks the Calo sent CICADA scores.

PR validation:

All code compiles and has had code formatting applied. This Unpacker has also been tested against events with the CaloSummary/CICADA cards in DAQ. A screenshot of some debugging output of the development of the unpacker is attached. On the left side you can see the unpacked data from FED 1356, which matches the dumped FED output seen on the right (CICADA/CaloSummary highlighted)

image

Also shown is a demonstration that the correct CICADA bits are received in the correct order, and the resulting constructed score, matched to the expected hex number (when transformed into a 16 bit fixed-point number, with 8 integer bits, and 8 bits after the decimal point, to within machine epsilon, or display precision).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, and is not expected to need a backport. It is however, a feature of an upcoming data-taking tool, so it is not impossible that a backport will be requested for it.

@eyigitba @slaurila FYI, this is one of the DPG requested pieces for CICADA that we have made for our own commissioning purposes now. Packers will be made when we are satisfied with commissioning progress using these unpackers.

aloeliger avatar May 24 '24 09:05 aloeliger

cms-bot internal usage

cmsbuild avatar May 24 '24 09:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40336

  • This PR adds an extra 24KB to repository

cmsbuild avatar May 24 '24 09:05 cmsbuild

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. @eyigitba, @thomreis, @Martin-Grunewald, @missirol, @dinyar this is something you requested to watch as well. @antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 24 '24 09:05 cmsbuild

test parameters: pull_requests = https://github.com/cms-sw/cmssw/pull/44222

aloeliger avatar May 24 '24 09:05 aloeliger

please test

aloeliger avatar May 24 '24 09:05 aloeliger

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1eda2/39510/summary.html COMMIT: 077e16de136872bdaa077a14340f9f837e021699 CMSSW: CMSSW_14_1_X_2024-05-23-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45037/39510/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338833
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 24 '24 12:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40671

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40671/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40671/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Jun 21 '24 15:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45037/40672

  • This PR adds an extra 24KB to repository

cmsbuild avatar Jun 21 '24 15:06 cmsbuild

Pull request #45037 was updated. @cmsbuild, @aloeliger, @epalencia can you please check and sign again.

cmsbuild avatar Jun 21 '24 15:06 cmsbuild

please test

aloeliger avatar Jun 21 '24 15:06 aloeliger

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1eda2/40014/summary.html COMMIT: bf7e8381e7b0cf4e951e87de1deacef2adb57f66 CMSSW: CMSSW_14_1_X_2024-06-20-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45037/40014/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345018
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344995
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jun 21 '24 19:06 cmsbuild

+l1

  • uGT unpacker is now ready

aloeliger avatar Jun 24 '24 21:06 aloeliger

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44222

cmsbuild avatar Jun 24 '24 21:06 cmsbuild

+1

rappoccio avatar Jun 25 '24 15:06 rappoccio

Congratulations. Merging this PR alone completely obliterated the IB CMSSW_14_1_X_2024-06-25-2300, https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_14_1_X

mmusich avatar Jun 26 '24 05:06 mmusich

I guess that's because:

Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44222

which is not yet ready to be merged ?

fwyzard avatar Jun 26 '24 05:06 fwyzard

@cms-sw/orp-l2 , we might not be able to converge on https://github.com/cms-sw/cmssw/pull/44222 before 11h00 IB. I would suggest to revert this PR for 11h00 ? Any objections @cms-sw/l1-l2 ?

smuzaffar avatar Jun 26 '24 07:06 smuzaffar

I have opened https://github.com/cms-sw/cmssw/pull/45308 ( which is revert of this PR)

smuzaffar avatar Jun 26 '24 07:06 smuzaffar

No objections here. I can sign the revert quickly.

My apologies for this, I thought this was tested and tagged with the uGT unpacker as external.

aloeliger avatar Jun 26 '24 07:06 aloeliger

My apologies for this, I thought this was tested and tagged with the uGT unpacker as external.

I think everything was done correctly on your side, but the requires-external flag was neglected when merging as pointed out at https://github.com/cms-sw/cmssw/pull/45037#issuecomment-2190746906 (see https://github.com/cms-sw/cms-bot/issues/2147 for a discussion of this general problem).

mmusich avatar Jun 26 '24 07:06 mmusich