cms-sw
RPCDigis validaiton module update
PR description:
This PR is to update the RPCDigis validation. Main motivation of the proposed change is to cleanup unused plots, fix empty plots if any and add more useful plots to perform the release validation.
The proposal for this update was presented in the RPC-DPG working meeting 22 May 2024: link to the slide
This PR addresses suggestions during the meeting, to keep the plots for residual distributions but fixing the (known) bug in the code. It only modifies/adds DQM plots during the validation step.
PR validation:
Performed tests on CMSSW_14_1_0_pre3 release
runTheMatrix.py -l 12834.0- Run cmsDriver step3 and step4 with the existing GEN-SIM-DIGI-RAW samples stored in eos (no crashes, DQM plots seems to be OK)
- code-checks OK
- code-format OK
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
We want to have backport to the currently active release cycles
- 14_0_X
- 14_1_X
Possible watchers: @mileva @mrcthiel
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45029/40320
- This PR adds an extra 28KB to repository
A new Pull Request was created by @jhgoh for master.
It involves the following packages:
- Validation/MuonRPCDigis (dqm)
@syuvivida, @cmsbuild, @tjavaid, @nothingface0, @antoniovagnerini, @rvenditti can you please review it and eventually sign? Thanks. @missirol, @JanFSchulte this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84599a/39502/summary.html
COMMIT: 5f5deb314a1e58404c6e094184a33578d43521e3
CMSSW: CMSSW_14_1_X_2024-05-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45029/39502/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 4 lines from the logs
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338037
- DQMHistoTests: Total failures: 0
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338017
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 21556.199999999993 KiB( 47 files compared)
- DQMHistoSizes: changed ( 10224.0,... ): 862.248 KiB RPCDigisV/RPCDigis
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84599a/39737/summary.html
COMMIT: 5f5deb314a1e58404c6e094184a33578d43521e3
CMSSW: CMSSW_14_1_X_2024-06-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45029/39737/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 9 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338149
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338123
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 21556.199999999993 KiB( 47 files compared)
- DQMHistoSizes: changed ( 10224.0,... ): 862.248 KiB RPCDigisV/RPCDigis
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
