cms-sw
Introduce a Long-track bonus in CkfTrackBuilder
I have introduced a bonus mechanism for candiate comparison in CkfTrackBuilder similar to the one present since long time in the Grouped one.
The main effect should be to have longer electrons. In this PR the default areno-op so no regression is expected. Muon and HLT has been left with no Bonus mechanism as well. An optimization procedures can be applied for Electrons, conversions and eventually Muons to determine the parameters for production .
The effect can be observed in the number of missing outer hits for electrons in zee events with pile-up (here for two values of the bonus 5 and 10 (10 is the default in grouped) http://innocent.home.cern.ch/innocent/RelVal/zeePu14Bonus/plots_gsf_electronGsf/hitsAndPt.pdf
Discussion scheduled in TRK-POG meeting on June 3rd.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45023/40315
-
This PR adds an extra 36KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): #43964
A new Pull Request was created by @VinInn for master.
It involves the following packages:
- HLTrigger/Configuration (hlt)
- RecoEgamma/EgammaPhotonProducers (reconstruction)
- RecoMuon/L3TrackFinder (hlt, reconstruction)
- RecoTracker/CkfPattern (reconstruction)
@mandrenguyen, @jfernan2, @Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. @ram1123, @dgulhan, @sameasy, @andrea21z, @sobhatta, @varuns23, @missirol, @mtosi, @abbiendi, @silviodonato, @gpetruc, @rociovilar, @JanFSchulte, @CeliaFernandez, @jainshilpi, @cericeci, @afiqaize, @jhgoh, @mmusich, @Sam-Harper, @felicepantaleo, @rovere, @HuguesBrun, @trocino, @lgray, @VourMa, @Martin-Grunewald, @Fedespring, @Prasant1993, @bellan, @GiacomoSguazzoni, @valsdav, @VinInn, @a-kapoor this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0b7d4/39487/summary.html
COMMIT: 3457dcbef74177b64bf427a1258f6fd8f657f2b6
CMSSW: CMSSW_14_1_X_2024-05-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45023/39487/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found 1 errors in the following unit tests:
---> test test_hltMenuContentToCSVs had ERRORS
Comparison Summary
Summary:
- You potentially removed 44 lines from the logs
- Reco comparison results: 19924 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3445370
- DQMHistoTests: Total failures: 3591
- DQMHistoTests: Total nulls: 5
- DQMHistoTests: Total successes: 3441754
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.094 KiB( 48 files compared)
- DQMHistoSizes: changed ( 141.042 ): 0.004 KiB JetMET/SUSYDQM
- DQMHistoSizes: changed ( 141.044 ): 0.090 KiB JetMET/SUSYDQM
- Checked 206 log files, 170 edm output root files, 49 DQM output files
- TriggerResults: found differences in 1 / 47 workflows
the test in question passed in my local area
[innocent@patatrack02 Configuration]$ scripts/utils/hltMenuContentToCSVs /dev/CMSSW_13_0_0/GRun --meta scripts/utils/hltPathOwners.json
./tabHLTPrescales.csv
./tabHLTMenu.csv
./tabHLTDatasetsAndStreams.csv
The DQM regressions are expected and expert need to validate at some point (after retuning?). I do not see the difference in TriggerResults: are all 0.
the test in question passed in my local area
It's likely a (transient) and unrelated connection glitch to confDB (at the same time of the failure, I observed other related failures).
. I do not see the difference in TriggerResults: are all 0.
See https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_1_X_2024-05-22-2300+d0b7d4/62856/triggerResults/141.044_RunJetMET2023D/reHLT.log
@mmusich would need to look to the menu to see if anything has been pulled out from the default instead of from the customizer...
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45023/40332
-
This PR adds an extra 40KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): #43964
Pull request #45023 was updated. @mmusich, @mandrenguyen, @jfernan2, @Martin-Grunewald, @cmsbuild can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45023/40333
- This PR adds an extra 40KB to repository
Pull request #45023 was updated. @mmusich, @jfernan2, @Martin-Grunewald, @mandrenguyen, @cmsbuild can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45023/40335
- This PR adds an extra 40KB to repository
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0b7d4/39507/summary.html
COMMIT: e4cbb5024d6d69616f985d06b2a95c51bfb3af92
CMSSW: CMSSW_14_1_X_2024-05-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45023/39507/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 16 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3445370
- DQMHistoTests: Total failures: 9
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3445341
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 206 log files, 170 edm output root files, 49 DQM output files
- TriggerResults: no differences found
@cms-sw/hlt-l2 @cms-sw/reconstruction-l2 are there any pending comments still? Please check/clarify. Thank you.
HLT was planning to sign after reco signs off (only obligatory config changes in HLT related packages)
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
@rappoccio @antoniovilela the PR is fully signed for two days now. What is the reason to further delay merging? Please clarify. Thank you.
