cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

[14_0_X backport] Stop `dz` from being `NaN` in `PackedCandidates`

Open swagata87 opened this issue 1 year ago • 8 comments

Backport of https://github.com/cms-sw/cmssw/pull/45009, as discussed in https://github.com/cms-sw/cmssw/issues/44976#issuecomment-2125654589

swagata87 avatar May 23 '24 12:05 swagata87

A new Pull Request was created by @swagata87 for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/PatCandidates (reconstruction, xpog)

@cmsbuild, @jfernan2, @hqucms, @vlimant, @mandrenguyen can you please review it and eventually sign? Thanks. @rovere, @missirol, @gpetruc, @hatakeyamak, @gouskos this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 23 '24 12:05 cmsbuild

cms-bot internal usage

cmsbuild avatar May 23 '24 12:05 cmsbuild

type pf

swagata87 avatar May 23 '24 12:05 swagata87

please test

jfernan2 avatar May 23 '24 14:05 jfernan2

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-599f65/39491/summary.html COMMIT: aeb680f63826c0041bde98b480bd4818b5948998 CMSSW: CMSSW_14_0_X_2024-05-23-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45022/39491/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 44 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3333953
  • DQMHistoTests: Total failures: 27
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3333906
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 23 '24 17:05 cmsbuild

+1

jfernan2 avatar May 24 '24 07:05 jfernan2

+1

vlimant avatar May 27 '24 06:05 vlimant

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 27 '24 06:05 cmsbuild

+1

rappoccio avatar May 29 '24 15:05 rappoccio