cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Run3-alca247Y Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs

Open bsunanda opened this issue 1 year ago • 11 comments

PR description:

Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs

PR validation:

Used these files in getting calibration constants for 2024 IsoTrack studies

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

nothing special

bsunanda avatar May 21 '24 14:05 bsunanda

cms-bot internal usage

cmsbuild avatar May 21 '24 14:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40292

  • Error: Found path names starting with digits: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40292/invalid-filenames.txt

  • This PR adds an extra 20KB to repository

cmsbuild avatar May 21 '24 14:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40293

  • This PR adds an extra 20KB to repository

  • Found files with invalid states:

    • Calibration/HcalCalibAlgos/macros/jobs/24BC.txt:
      • Added: 5923a8d37472a1e022e502a0b7fe4250fa8ebb16
      • Deleted: bbc783d6ad1220f4cbfdeb2ba6774a4ef2bf815a
    • Calibration/HcalCalibAlgos/macros/jobs/24CC.txt:
      • Added: 5923a8d37472a1e022e502a0b7fe4250fa8ebb16
      • Deleted: bbc783d6ad1220f4cbfdeb2ba6774a4ef2bf815a

cmsbuild avatar May 21 '24 15:05 cmsbuild

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Calibration/HcalCalibAlgos (alca)

@consuegs, @perrotta, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks. @tocheng, @rsreds, @mmusich, @yuanchao this is something you requested to watch as well. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 21 '24 15:05 cmsbuild

@cmsbuild Please test

bsunanda avatar May 21 '24 15:05 bsunanda

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ad46/39455/summary.html COMMIT: bbc783d6ad1220f4cbfdeb2ba6774a4ef2bf815a CMSSW: CMSSW_14_1_X_2024-05-20-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45010/39455/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar May 21 '24 18:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40304

  • This PR adds an extra 20KB to repository

  • Found files with invalid states:

    • Calibration/HcalCalibAlgos/macros/jobs/24BC.txt:
      • Added: 5923a8d37472a1e022e502a0b7fe4250fa8ebb16
      • Deleted: bbc783d6ad1220f4cbfdeb2ba6774a4ef2bf815a
    • Calibration/HcalCalibAlgos/macros/jobs/24CC.txt:
      • Added: 5923a8d37472a1e022e502a0b7fe4250fa8ebb16
      • Deleted: bbc783d6ad1220f4cbfdeb2ba6774a4ef2bf815a

cmsbuild avatar May 22 '24 16:05 cmsbuild

Pull request #45010 was updated. @consuegs, @perrotta, @cmsbuild, @saumyaphor4252 can you please check and sign again.

cmsbuild avatar May 22 '24 16:05 cmsbuild

@cmsbuild Please test

bsunanda avatar May 22 '24 16:05 bsunanda

@bsunanda could you also please squash the commits, to get rid of files with invalid states in the git history?

perrotta avatar May 22 '24 17:05 perrotta

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ad46/39472/summary.html COMMIT: c61d014824d9e48b9ade0f592a57876fe8eff5d9 CMSSW: CMSSW_14_1_X_2024-05-22-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45010/39472/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338839
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 22 '24 19:05 cmsbuild

@bsunanda please squash the commits, to get rid of files with invalid states in the git history

perrotta avatar May 25 '24 12:05 perrotta

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40349

  • This PR adds an extra 20KB to repository

  • Found files with invalid states:

    • Calibration/HcalCalibAlgos/macros/jobs/24BC.txt:
      • Added: 888486648091073b232f79a20bcffe81e0542ace
      • Deleted: 6bc5acf11969ad0666964d9d74a8cbe9571f582d
    • Calibration/HcalCalibAlgos/macros/jobs/24CC.txt:
      • Added: 888486648091073b232f79a20bcffe81e0542ace
      • Deleted: 6bc5acf11969ad0666964d9d74a8cbe9571f582d
  • There are other open Pull requests which might conflict with changes you have proposed:

    • File RecoTracker/CkfPattern/interface/CkfTrajectoryBuilder.h modified in PR(s): #45023
    • File RecoTracker/CkfPattern/plugins/TrajectorySegmentBuilder.cc modified in PR(s): #45023
    • File RecoTracker/CkfPattern/src/CkfTrajectoryBuilder.cc modified in PR(s): #45023

cmsbuild avatar May 26 '24 04:05 cmsbuild

Pull request #45010 was updated. @cmsbuild, @saumyaphor4252, @consuegs, @mandrenguyen, @Dr15Jones, @smuzaffar, @jfernan2, @perrotta, @makortel can you please check and sign again.

cmsbuild avatar May 26 '24 04:05 cmsbuild

Destroyed the PR by attempting squashing. A new PR is made in #45045

bsunanda avatar May 26 '24 04:05 bsunanda