cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

(DAQ) remove dummy MicroStateService

Open smorovic opened this issue 1 year ago • 20 comments

PR description:

Removes dummy MicroStateService class and changes to using FastMonitoringService directly

PR validation:

Tested in DAQ test setup (online HLT emulation) with no issues seen.

smorovic avatar May 16 '24 21:05 smorovic

cms-bot internal usage

cmsbuild avatar May 16 '24 21:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40271

  • This PR adds an extra 88KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): #44372
    • File EventFilter/Utilities/plugins/GlobalEvFOutputModule.cc modified in PR(s): #44892
    • File EventFilter/Utilities/src/DAQSource.cc modified in PR(s): #44979
    • File EventFilter/Utilities/src/EvFDaqDirector.cc modified in PR(s): #44892
    • File EventFilter/Utilities/src/FedRawDataInputSource.cc modified in PR(s): #44892, #44979
    • File HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoring.cc modified in PR(s): #44989
    • File HLTrigger/JSONMonitoring/plugins/L1TriggerJSONMonitoring.cc modified in PR(s): #44989

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40271/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40271/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar May 16 '24 21:05 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40272

  • This PR adds an extra 88KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): #44372
    • File EventFilter/Utilities/plugins/GlobalEvFOutputModule.cc modified in PR(s): #44892
    • File EventFilter/Utilities/src/DAQSource.cc modified in PR(s): #44979
    • File EventFilter/Utilities/src/EvFDaqDirector.cc modified in PR(s): #44892
    • File EventFilter/Utilities/src/FedRawDataInputSource.cc modified in PR(s): #44892, #44979
    • File HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoring.cc modified in PR(s): #44989
    • File HLTrigger/JSONMonitoring/plugins/L1TriggerJSONMonitoring.cc modified in PR(s): #44989

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40272/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40272/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar May 16 '24 21:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40273

  • This PR adds an extra 88KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): #44372
    • File EventFilter/Utilities/plugins/GlobalEvFOutputModule.cc modified in PR(s): #44892
    • File EventFilter/Utilities/src/DAQSource.cc modified in PR(s): #44979
    • File EventFilter/Utilities/src/EvFDaqDirector.cc modified in PR(s): #44892
    • File EventFilter/Utilities/src/FedRawDataInputSource.cc modified in PR(s): #44892, #44979
    • File HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoring.cc modified in PR(s): #44989
    • File HLTrigger/JSONMonitoring/plugins/L1TriggerJSONMonitoring.cc modified in PR(s): #44989

cmsbuild avatar May 16 '24 21:05 cmsbuild

A new Pull Request was created by @smorovic for master.

It involves the following packages:

  • DQMServices/FileIO (dqm)
  • EventFilter/Utilities (daq)
  • HLTrigger/JSONMonitoring (hlt)

@cmsbuild, @smorovic, @antoniovagnerini, @Martin-Grunewald, @emeschi, @rvenditti, @syuvivida, @nothingface0, @tjavaid, @mmusich can you please review it and eventually sign? Thanks. @barvic, @Martin-Grunewald, @silviodonato, @fwyzard, @missirol this is something you requested to watch as well. @antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 16 '24 21:05 cmsbuild

@cmsbuild please test with https://github.com/cms-sw/cmssw/pull/44372 https://github.com/cms-sw/cmssw/pull/44892 https://github.com/cms-sw/cmssw/pull/44979 https://github.com/cms-sw/cmssw/pull/44989

smorovic avatar May 16 '24 21:05 smorovic

@cmsbuild please test with https://github.com/cms-sw/cmssw/pull/44372, https://github.com/cms-sw/cmssw/pull/44892, https://github.com/cms-sw/cmssw/pull/44979, https://github.com/cms-sw/cmssw/pull/44989

smorovic avatar May 16 '24 21:05 smorovic

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8a380/39418/summary.html COMMIT: 706461889fa6042101af30e4cc4c3858acb14b1a CMSSW: CMSSW_14_1_X_2024-05-16-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44991/39418/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it? You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8a380/39418/git-merge-result

cmsbuild avatar May 16 '24 22:05 cmsbuild

@cmsbuild please hold

postponing solving the conflict until other PRs touching same files are merged.

smorovic avatar May 17 '24 06:05 smorovic

it is due to https://github.com/cms-sw/cmssw/pull/44372

smorovic avatar May 17 '24 06:05 smorovic

hold

smorovic avatar May 17 '24 07:05 smorovic

Pull request has been put on hold by @smorovic They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar May 17 '24 07:05 cmsbuild

it is due to https://github.com/cms-sw/cmssw/pull/44372

@smorovic that PR needs more work, so feel free to remove it from your tests, I don't think it will be merged soon.

mmusich avatar May 17 '24 07:05 mmusich

unhold

smorovic avatar May 17 '24 07:05 smorovic

please test with https://github.com/cms-sw/cmssw/pull/44892, https://github.com/cms-sw/cmssw/pull/44979, https://github.com/cms-sw/cmssw/pull/44989

(4472 is test only)

smorovic avatar May 17 '24 07:05 smorovic

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8a380/39419/summary.html COMMIT: 706461889fa6042101af30e4cc4c3858acb14b1a CMSSW: CMSSW_14_1_X_2024-05-16-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44991/39419/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338953
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 17 '24 09:05 cmsbuild

+daq

smorovic avatar May 17 '24 09:05 smorovic

+1

Martin-Grunewald avatar May 21 '24 06:05 Martin-Grunewald

+1

tjavaid avatar May 23 '24 14:05 tjavaid

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44892

cmsbuild avatar May 23 '24 14:05 cmsbuild

+1

rappoccio avatar May 29 '24 15:05 rappoccio