(DAQ) jsoncpp moved to a namespace (14_0_X backport)
PR description:
Moved to jsoncollector namespace to avoid conflict with tensorflow import of this lib (newer version).
PR validation:
Tested in DAQ test system and produces valid json files.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #44989 See also: https://github.com/cms-sw/cmssw/issues/44975
A new Pull Request was created by @smorovic for CMSSW_14_0_X.
It involves the following packages:
- EventFilter/Utilities (daq)
- HLTrigger/JSONMonitoring (hlt)
@mmusich, @smorovic, @Martin-Grunewald, @emeschi, @cmsbuild can you please review it and eventually sign? Thanks. @fwyzard, @silviodonato, @missirol, @Martin-Grunewald this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
- Backported from #44989
cms-bot internal usage
@cmsbuild please test
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab658b/39416/summary.html
COMMIT: 6da420fcb3268d4a863666666c4e9dc025ec887c
CMSSW: CMSSW_14_0_X_2024-05-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44990/39416/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @rseidita cms-sw/cmssw#44960
- @rseidita cms-sw/cmssw#44953
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab658b/39416/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab658b/39416/git-merge-result
Comparison Summary
Summary:
- You potentially added 88 lines to the logs
- Reco comparison results: 60 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3333953
- DQMHistoTests: Total failures: 1982
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3331951
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+daq
+hlt
- verified that this PR on top of
CMSSW_14_0_X_2024-05-16-2300passes the test with recipe at https://github.com/cms-sw/cmssw/issues/44975#issue-2297728164
type bug-fix
backport of https://github.com/cms-sw/cmssw/pull/44989
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
+1