cms-sw
(DAQ) jsoncpp moved to a namespace (14_1_X)
PR description:
Moved to jsoncollector namespace to avoid conflict with tensorflow import of this lib (newer version).
PR validation:
Tested in DAQ test system and produces valid json files.
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44989/40267
- This PR adds an extra 56KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
- code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44989/40267/code-format.patch
e.g.
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44989/40267/code-format.patch | patch -p1You can also runscram build code-formatto apply code format directly
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44989/40268
- This PR adds an extra 68KB to repository
A new Pull Request was created by @smorovic for master.
It involves the following packages:
- EventFilter/Utilities (daq)
- HLTrigger/JSONMonitoring (hlt)
@cmsbuild, @Martin-Grunewald, @smorovic, @emeschi, @mmusich can you please review it and eventually sign? Thanks. @fwyzard, @missirol, @silviodonato, @Martin-Grunewald this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c75752/39415/summary.html
COMMIT: 0d93dfb7c60d2168aef38b32a33befe498763f62
CMSSW: CMSSW_14_1_X_2024-05-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44989/39415/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 6 lines from the logs
- Reco comparison results: 12 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338976
- DQMHistoTests: Total failures: 15
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338941
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+hlt
- see https://github.com/cms-sw/cmssw/pull/44990#issuecomment-2116677099
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
