cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Enable SoA range checking by default [14.0.x]

Open fwyzard opened this issue 1 year ago • 8 comments

PR description:

Enable SoA range checking by default.

PR validation:

None.

Backport status:

Backport of #44988 for data taking.

fwyzard avatar May 16 '24 15:05 fwyzard

please test

fwyzard avatar May 16 '24 15:05 fwyzard

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/SoATemplate (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks. @rovere, @missirol this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

  • Backported from #44988

cmsbuild avatar May 16 '24 15:05 cmsbuild

cms-bot internal usage

cmsbuild avatar May 16 '24 15:05 cmsbuild

backport #44988

fwyzard avatar May 16 '24 15:05 fwyzard

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ddcd0/39411/summary.html COMMIT: 96a8e492de9f3c67cd9c217a758ffa81f8294957 CMSSW: CMSSW_14_0_X_2024-05-16-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44987/39411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3333953
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3333927
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 16 '24 19:05 cmsbuild

Pull request #44987 was updated. @makortel, @fwyzard, @cmsbuild can you please check and sign again.

cmsbuild avatar May 20 '24 09:05 cmsbuild

please test

fwyzard avatar May 20 '24 09:05 fwyzard

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ddcd0/39432/summary.html COMMIT: 679de0b0cc149b77fe6d2d42433207548e44e4cb CMSSW: CMSSW_14_0_X_2024-05-19-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44987/39432/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar May 20 '24 12:05 cmsbuild

+heterogeneous

fwyzard avatar Jun 05 '24 13:06 fwyzard

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jun 05 '24 13:06 cmsbuild

please test

(to refresh the test results)

fwyzard avatar Jun 05 '24 14:06 fwyzard

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ddcd0/39716/summary.html COMMIT: 679de0b0cc149b77fe6d2d42433207548e44e4cb CMSSW: CMSSW_14_0_X_2024-06-05-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44987/39716/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Jun 05 '24 17:06 cmsbuild

+1

rappoccio avatar Jun 06 '24 13:06 rappoccio