cms-sw
[DBG] Fix undefined ref errors in L1TMuonOverlapPhase2
PR description:
This fixes #44946 It also needs cms-sw/cmsdist#9193 for DBG IBs Supersedes #44974
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44984/40264
-
This PR adds an extra 20KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1TMuonOverlapPhase2/interface/LutNeuronLayerFixedPoint.h modified in PR(s): #44974
A new Pull Request was created by @mbluj for master.
It involves the following packages:
- L1Trigger/L1TMuonOverlapPhase2 (upgrade, l1)
@cmsbuild, @srimanob, @subirsarkar, @aloeliger, @epalencia can you please review it and eventually sign? Thanks. @missirol, @dinyar, @eyigitba, @thomreis, @JanFSchulte, @Martin-Grunewald this is something you requested to watch as well. @sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06e4be/39406/summary.html
COMMIT: d37754178fdfcd51733b817112692900c5520e41
CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44984/39406/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 3 lines to the logs
- Reco comparison results: 6 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338976
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338953
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
Previously used constexpr static const int replaced by more compact static constexpr int with same meaning.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44984/40278
- This PR adds an extra 24KB to repository
Pull request #44984 was updated. @subirsarkar, @srimanob, @aloeliger, @epalencia, @cmsbuild can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06e4be/39422/summary.html
COMMIT: 3f21c2850a7ae2a12b3318ffa6a6e23eb5d98035
CMSSW: CMSSW_14_1_X_2024-05-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44984/39422/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 2 lines from the logs
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3338976
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3338950
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
