cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Adding PPS and ECALTiming Runs to HLT Menu veto of PCL alignment

Open phnattla opened this issue 1 year ago • 8 comments

PR description:

Added the "special" HLT menus PPS and ECALTiming to the veto_HLT_Menu for the PCL alignment, so that such runs are not used in the PCL alignment.

PR validation:

PR was validated by testing the MilleStep for a PPS run (Run 379060) and a ECALTiming run (Run 379354), using the following command:

cmsDriver.py milleStep -s ALCA:PromptCalibProdSiPixelAli --conditions 140X_dataRun3_Express_v2 --scenario pp --data --era Run3 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100 --dasquery='file dataset=/StreamExpress/Run2024B-TkAlMinBias-Express-v1/ALCARECO run=<379060, 379354>'

@mmusich @dmeuser @henriettepetersen @TomasKello

phnattla avatar May 16 '24 11:05 phnattla

cms-bot internal usage

cmsbuild avatar May 16 '24 11:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44983/40263

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Alignment/CommonAlignmentProducer/python/LSNumberFilter_cfi.py modified in PR(s): #44368

cmsbuild avatar May 16 '24 11:05 cmsbuild

A new Pull Request was created by @phnattla for master.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)

@saumyaphor4252, @perrotta, @cmsbuild, @consuegs can you please review it and eventually sign? Thanks. @pakhotin, @adewit, @rsreds, @tlampen, @mmusich, @tocheng, @yuanchao this is something you requested to watch as well. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar May 16 '24 11:05 cmsbuild

test parameters:

  • workflows = 1001.0, 1001.2, 1001.3, 1001.4, 1002.3

mmusich avatar May 16 '24 12:05 mmusich

@cmsbuild, please test

mmusich avatar May 16 '24 12:05 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c4ed1/39407/summary.html COMMIT: 52986abff7226b2d3c4c754aeb8e1360747c17b8 CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44983/39407/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3368968
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3368942
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 223 log files, 169 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar May 16 '24 14:05 cmsbuild

+alca

perrotta avatar May 16 '24 19:05 perrotta

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar May 16 '24 19:05 cmsbuild

+1

rappoccio avatar May 20 '24 14:05 rappoccio